[MRG] Replace flake8 linting with ruff linting
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asoplata reviewed and looks good to me. once the conflict is resolved i'll merge this |
Note: for anyone doing testing on an existing install, this DOES require that you will have to install the `ruff` Python package. Alternatively, you can also install `ruff` by re-installing the development packages the same way you originally installed `flake8`, via: `pip install --editable "<your_hnn_dir>[dev]"`
asoplata
force-pushed
the
replace-flake8-linting-ruff
branch
from
8dd3bcd to
2295fc8
Compare
|
@dylansdaniels This has been rebased and is now ready for merge with |
|
@dylansdaniels Actually, dont' merge yet, I forgot to make the manual comment changes that you suggested |
|
This is now ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change for the purposes of replacing our previous linting with
flake8to use the fasterruff checklinting. For previous discussion on why this is a good idea, see the parts of #934 discussingrufflinting specifically (as opposed to "formatting"). This PR was forked off from that discussion. Note that this current PR is NOT about usingruff formatto change our code-formatting-style. Instead, the "linting" inruff checkis limited to error detection (such as syntax errors) and some limited PEP8 formatting violation detection. Again, see the other issue for a more exhaustive discussion of these things, including the terminology around them.Note: for anyone doing testing on an existing install, this DOES require that you will have to install the
ruffPython package. Alternatively, you can also installruffby re-installing the development packages the same way you originally installedflake8, via:pip install --editable "<your_hnn_dir>[dev]"