chore: Simplify generated tests

jolicode · Apr 3, 2024 · 45424c4 · 45424c4
1 parent 4bae84b
commit 45424c4
Show file tree

Hide file tree

Showing 80 changed files with 97 additions and 396 deletions.
diff --git a/bin/generate-tests.php b/bin/generate-tests.php
@@ -145,7 +145,7 @@
 add_test(['enabled:hello', '--context', 'production'], 'EnabledInProduction');
 add_test(['list', '--raw', '--format', 'txt', '--short'], 'ListTest', skipOnBinary: true);
 add_test(['parallel:sleep', '--sleep5', '0', '--sleep7', '0', '--sleep10', '0'], 'ParallelSleepTest');
-add_test(['symfony:greet', 'World', '--french', 'COUCOU', '--punctuation', '!' ], 'SymfonyGreetTest', skipOnBinary: true);
+add_test(['symfony:greet', 'World', '--french', 'COUCOU', '--punctuation', '!'], 'SymfonyGreetTest', skipOnBinary: true);
 add_test(['symfony:hello'], 'SymfonyHelloTest', skipOnBinary: true);
 // In /tmp
 add_test(['completion', 'bash'], 'NoConfigCompletionTest', '/tmp');
@@ -174,6 +174,8 @@ function add_test(array $args, string $class, ?string $cwd = null, bool $needRem
     );
     $process->run();
 
+    $err = OutputCleaner::cleanOutput($process->getErrorOutput());
+
     $code = strtr($template, [
         '{{ class_name }}' => $class,
         '{{ task }}' => $args[0] ?? 'no task',
@@ -184,18 +186,25 @@ function add_test(array $args, string $class, ?string $cwd = null, bool $needRem
         '{{ skip-on-binary }}' => match ($skipOnBinary) {
             true => <<<'PHP'
 
-                    if (self::$binary) {
-                        $this->markTestSkipped('This test is not compatible with the binary version of Castor.');
-                    }
+                        if (self::$binary) {
+                            $this->markTestSkipped('This test is not compatible with the binary version of Castor.');
+                        }
 
-            PHP,
+                PHP,
             default => '',
         },
+        '{{ error-assertion }}' => match ((bool) $err) {
+            true => <<<'PHP'
+                $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
+                PHP,
+            default => <<<'PHP'
+                $this->assertSame('', $process->getErrorOutput());
+                PHP,
+        },
     ]);
 
     file_put_contents(__DIR__ . '/../tests/Examples/Generated/' . $class . '.php', $code);
     file_put_contents(__DIR__ . '/../tests/Examples/Generated/' . $class . '.php.output.txt', OutputCleaner::cleanOutput($process->getOutput()));
-    $err = OutputCleaner::cleanOutput($process->getErrorOutput());
     if ($err) {
         file_put_contents(__DIR__ . '/../tests/Examples/Generated/' . $class . '.php.err.txt', $err);
     }
@@ -217,10 +226,6 @@ public function test(): void
 
         $this->assertSame({{ exitCode }}, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        {{ error-assertion }}
     }
 }
diff --git a/examples/symfony.php b/examples/symfony.php
@@ -15,7 +15,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 #[AsCommand('hello', 'Says hello from a symfony application')]
-#[AsSymfonyTask(name: 'symfony:hello', console: [PHP_BINARY, __FILE__])] // We need to force PHP binary to support windows
+#[AsSymfonyTask(name: 'symfony:hello', console: [\PHP_BINARY, __FILE__])] // We need to force PHP binary to support windows
 class HelloCommand extends Command
 {
     protected function execute(InputInterface $input, OutputInterface $output): int
@@ -27,7 +27,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 }
 
 #[AsCommand('greet')]
-#[AsSymfonyTask(name: 'symfony:greet', console: [PHP_BINARY, __FILE__])] // We need to force PHP binary to support windows
+#[AsSymfonyTask(name: 'symfony:greet', console: [\PHP_BINARY, __FILE__])] // We need to force PHP binary to support windows
 class GreetCommand extends Command
 {
     protected function configure(): void

diff --git a/tests/Examples/Generated/ArgPassthruExpanded.php b/tests/Examples/Generated/ArgPassthruExpanded.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ArgsAnotherArgsTest.php b/tests/Examples/Generated/ArgsAnotherArgsTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ArgsArgsTest.php b/tests/Examples/Generated/ArgsArgsTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ArgsAutocompleteArgumentTest.php b/tests/Examples/Generated/ArgsAutocompleteArgumentTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ArgsPassthruTest.php b/tests/Examples/Generated/ArgsPassthruTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/AutocompleteInvalidTest.php b/tests/Examples/Generated/AutocompleteInvalidTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(1, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/BarBarTest.php b/tests/Examples/Generated/BarBarTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/CacheComplexTest.php b/tests/Examples/Generated/CacheComplexTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/CacheSimpleTest.php b/tests/Examples/Generated/CacheSimpleTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/CdDirectoryTest.php b/tests/Examples/Generated/CdDirectoryTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextDoNotExistTest.php b/tests/Examples/Generated/ContextContextDoNotExistTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(1, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextDynamicTest.php b/tests/Examples/Generated/ContextContextDynamicTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextInfoForcedTest.php b/tests/Examples/Generated/ContextContextInfoForcedTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextMyDefaultTest.php b/tests/Examples/Generated/ContextContextMyDefaultTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextPathTest.php b/tests/Examples/Generated/ContextContextPathTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextProductionTest.php b/tests/Examples/Generated/ContextContextProductionTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextRunTest.php b/tests/Examples/Generated/ContextContextRunTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextTest.php b/tests/Examples/Generated/ContextContextTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextContextWithTest.php b/tests/Examples/Generated/ContextContextWithTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextGeneratorArg2Test.php b/tests/Examples/Generated/ContextGeneratorArg2Test.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(1, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextGeneratorArgTest.php b/tests/Examples/Generated/ContextGeneratorArgTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(1, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/ContextGeneratorNotCallableTest.php b/tests/Examples/Generated/ContextGeneratorNotCallableTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(1, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/EnabledInProduction.php b/tests/Examples/Generated/EnabledInProduction.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/EnvEnvTest.php b/tests/Examples/Generated/EnvEnvTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/EventListenerMyTaskTest.php b/tests/Examples/Generated/EventListenerMyTaskTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertSame('', $process->getErrorOutput());
     }
 }
diff --git a/tests/Examples/Generated/FailureAllowFailureTest.php b/tests/Examples/Generated/FailureAllowFailureTest.php
@@ -13,10 +13,6 @@ public function test(): void
 
         $this->assertSame(0, $process->getExitCode());
         $this->assertStringEqualsFile(__FILE__ . '.output.txt', $process->getOutput());
-        if (file_exists(__FILE__ . '.err.txt')) {
-            $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
-        } else {
-            $this->assertSame('', $process->getErrorOutput());
-        }
+        $this->assertStringEqualsFile(__FILE__ . '.err.txt', $process->getErrorOutput());
     }
 }