Skip to content

Commit

Permalink
fix “today” parsing (#2153)
Browse files Browse the repository at this point in the history
  • Loading branch information
fcurella authored Jan 22, 2025
1 parent 543de45 commit 9d0aff1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion faker/providers/date_time/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ def _parse_date_time(cls, value: DateParseType, now: datetime, tzinfo: Optional[
if isinstance(value, timedelta):
return datetime_to_timestamp(now + value)
if isinstance(value, str):
if value == "now":
if value in ("today", "now"):
return datetime_to_timestamp(datetime.now(tzinfo))
time_params = cls._parse_date_string(value)
return datetime_to_timestamp(now + timedelta(**time_params)) # type: ignore
Expand Down
8 changes: 8 additions & 0 deletions tests/providers/test_date_time.py
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,14 @@ def test_date_between(self):
assert isinstance(random_date, date)
self.assertBetween(random_date, _30_years_ago, _20_years_ago)

def test_date_between_end_today(self):
today = date.today()
_30_years_ago = change_year(today, -30)
random_date = self.fake.date_between(start_date="-30y", end_date="today")
assert isinstance(random_date, date)
self.assertBetween(random_date, _30_years_ago, today)


def test_date_between_months(self):

Check failure on line 454 in tests/providers/test_date_time.py

View workflow job for this annotation

GitHub Actions / flake8

too many blank lines (2)
today = date.today()
_2_months_ago = today - timedelta(days=2 * (365.24 / 12))
Expand Down

0 comments on commit 9d0aff1

Please sign in to comment.