WIP: initial commit for overpass wrapper with builder pattern #1

wolfhardfehre · 2016-11-15T21:02:23Z

four main query builder classes ComplexQuery, NodeQuery, WayQuery and RelationQuery
three option builder classes for
-- header settings (Settings)
-- regional search requests (SearchRegion)
-- filter tags (Tags)
six sign specific enums to define
-- verbosity level (Verbosity)
-- geometries (GeometryType)
-- comparison filters for tags (Filter)
-- possible regional search types (SearchType)
-- input specific selection types (Selection)
-- output specific modifier (Modifier)
two additional statement classes to allow recursion (Recursion) and building resulting sets (Sets)
three base type as interfaces and abstract classes to give the four main classes and the additional statements an architecture

- four main query builder classes ComplexQuery, NodeQuery, WayQuery and RelationQuery - three option builder classes for header settings (Settings), regional search requests (SearchRegion) and for filter tags (Tags) - six sign specific enums to define verbosity level (Verbosity), geometries (GeometryType), comparison filters for tags (Filter), possible regional search types (SearchType), input specific selection types (Selection) and output specific modifier (Modifier) - two additional statement classes to allow recursion (Recursion) and building resulting sets (Sets) - three base type as interfaces and abstract classes to give the four main classes and the additional statements an architecture

wolfhardfehre · 2016-11-15T21:41:45Z

This is just work in progress. README still needs to be adjusted to the new style and some examples should be presented. I also didn't test the OverpassResponse yet if it fits all the verbosity levels and geometry types.

johnjohndoe · 2016-11-17T13:56:24Z

Great 👍 I think I will have time to review it ~~within the next week~~.

johnjohndoe · 2016-12-12T19:32:38Z

Sorry, I am still too busy. Do not take this personally.

johnjohndoe

Thank you for the huge and great pull request. As we already spoke in person about this you know that I was taking an almost infinite time to review it. I hope you find my comments somewhat helpful. Please take your time to go through them. I will be happy to reply to any questions you have concerning them.

Test syntax

Did you see that I added AssertJ as a dependency? You might want to use it to make assertions more readable. Example:

Assert.assertEquals(expected, actual);

becomes:

assertThat(actual).isEqualTo(expected);

johnjohndoe · 2017-11-04T20:31:46Z

src/main/java/info/metadude/java/library/overpass/models/query/options/SearchRegion.java

+        for (double coordinate : coordinates) {
+            coo.add(String.valueOf(coordinate));
+        }
+        return String.join(delimiter, coo);


Replace with StringUtils.join.

johnjohndoe · 2017-11-04T20:31:55Z

src/main/java/info/metadude/java/library/overpass/models/query/options/Tags.java

+     * @return String
+     */
+    public String create() {
+        return String.join("", tags);


Replace with StringUtils.join.

johnjohndoe · 2017-11-04T20:32:04Z

src/main/java/info/metadude/java/library/overpass/models/query/statements/base/BaseType.java

+            tail.add(String.valueOf(limit));
+        }
+
+        return String.join(" ", tail);


Replace with StringUtils.join.

johnjohndoe · 2017-11-04T20:36:22Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Modifier.java

+ *  COUNT       Get the element count.
+ */
+public enum Modifier {
+    BB("bb"),


As you know I am not into the internals over the overpass query language. But as a library user I would love to see an a bit more verbose name for this enum. Maybe BBOX or even BOUNDING_BOX. In the end it should match what is defined in SearchType.

johnjohndoe · 2017-11-04T20:37:52Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Verbosity.java

+package info.metadude.java.library.overpass.models.query.enums;
+
+/**
+ * Degree of verbosity, default is body.


Where does this enum class define a default?

johnjohndoe · 2017-11-04T20:59:57Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Filter.java

+    LIKE("\"~\""),
+    NOTLIKE("\"!~\"");
+
+    public String sign;


Add final.

johnjohndoe · 2017-11-04T21:00:13Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Selection.java

+    BACKWARD_WAY("bw"),
+    BACKWARD_RELATION("br");
+
+    public String sign;


Add final.

johnjohndoe · 2017-11-04T21:00:31Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Verbosity.java

+    IDS("ids"),
+    TAGS("tags");
+
+    public String sign;


Add final.

johnjohndoe · 2017-11-04T21:00:52Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Modifier.java

+    GEOM("geom"),
+    COUNT("count");
+
+    public String sign;


Add final.

johnjohndoe · 2017-11-04T21:02:40Z

src/main/java/info/metadude/java/library/overpass/models/query/enums/Filter.java

+/**
+ * Tag request clauses (or "tag filters")
+ */
+public enum Filter {


For readability reasons I suggest adding _ in the enum values such as NOT_EQUAL instead of NOTEQUAL.

- introduction part in README to new lib design

wolfhardfehre · 2017-11-19T17:38:46Z

Still Todo

check what is wrong with travis
check responses with node, way, relation and complex query, probably write TypeAdapter
check responses for different modifiers
check responses for different verbosity levels

wolfhardfehre · 2017-12-03T14:58:37Z

@johnjohndoe I still have two major problems.

The first one is related to testing, I can't use the test suite integrated into Android Studio and have to test always just with ./gradlew test. But this is not as verbose as the Studio integration. Does it also happen to you? The error is related to Android Studio not finding a TestSuite (maybe because there is no androidTest folder). When I run then ./gradlew test it seams to cache this result and when I run afterwards the specific test with Android Studios Run it gives me the cached result back. If I then change the Test it still shows the last ./gradlew test result. I think that could be more comfortable but I have my work around.

The second problem has no work around. I don't know how to fix the following Travis error
ERROR: JAVA_HOME is set to an invalid directory: /usr/lib/jvm/java-7-oracle
Where is this happening? Is it on server side? Can you fix it or tell me what needs to be changed?

…d comments still missing

wolfhardfehre added 2 commits November 15, 2016 21:59

make it working with java 7

579041a

johnjohndoe requested changes Nov 4, 2017

View reviewed changes

johnjohndoe added the enhancement label Nov 4, 2017

Nice Fontaine and others added 6 commits November 6, 2017 23:22

made variables and methods more readable

081064e

use AssertJ for test assertions

15a1322

changes in design due to README introduction

09b7a3a

- introduction part in README to new lib design

insert simple example to README

e3d11c6

implemented ilike and Alexanderplatz README example

e77a60e

insert public transport example to README and tested examples

201c44e

wolfhardfehre and others added 11 commits December 3, 2017 20:43

basic Node, Way and Relation for OverpassResponse

079f96f

testing response classes

81c78a0

implemented MemberAdapter

9cf656e

add ElementJson and ElementAdpater for Moshi

ddb2edf

tested MemberAdapter

71a260e

completed response elements with iso 8601 date adapter, some tests an…

b1e57cf

…d comments still missing

full test coverage on Osm3s

cf02045

tested OverpassResponse

a63e62b

tmp

840ea8b

repaired moshi sub adaption

6598d07

tested bounds + count and renamed rest interface

c6b30e2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: initial commit for overpass wrapper with builder pattern #1

WIP: initial commit for overpass wrapper with builder pattern #1

wolfhardfehre commented Nov 15, 2016 •

edited by johnjohndoe

Loading

wolfhardfehre commented Nov 15, 2016

johnjohndoe commented Nov 17, 2016 •

edited

Loading

johnjohndoe commented Dec 12, 2016

johnjohndoe left a comment •

edited

Loading

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

johnjohndoe Nov 4, 2017

wolfhardfehre commented Nov 19, 2017 •

edited

Loading

wolfhardfehre commented Dec 3, 2017

WIP: initial commit for overpass wrapper with builder pattern #1

Are you sure you want to change the base?

WIP: initial commit for overpass wrapper with builder pattern #1

Conversation

wolfhardfehre commented Nov 15, 2016 • edited by johnjohndoe Loading

wolfhardfehre commented Nov 15, 2016

johnjohndoe commented Nov 17, 2016 • edited Loading

johnjohndoe commented Dec 12, 2016

johnjohndoe left a comment • edited Loading

Choose a reason for hiding this comment

Test syntax

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfhardfehre commented Nov 19, 2017 • edited Loading

wolfhardfehre commented Dec 3, 2017

wolfhardfehre commented Nov 15, 2016 •

edited by johnjohndoe

Loading

johnjohndoe commented Nov 17, 2016 •

edited

Loading

johnjohndoe left a comment •

edited

Loading

wolfhardfehre commented Nov 19, 2017 •

edited

Loading