-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration for Brink Renovent 300 and 400 #406
Conversation
2ec15ba
to
9614c99
Compare
- Renovent Excellent 300 and 400 (Tested on Sky300) - CO2 sensor (untested) - Zone valve (untested)
9614c99
to
68eeaf7
Compare
…ations; added German Trranslations
*w,Excellent300,,,,3c, | ||
|
||
## ALLGEMEINE HRU BEFEHLE ## (WTWCommands.cs - Einige davon sind möglicherweise nicht für dieses Gerät anwendbar, mit Vorsicht verwenden) | ||
w,,RücksetzenAufWerkseinstellung,FactoryReset,,,40ff,466163746f72795265736574 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the files are generated, so please make the message and field names identical in en+de, which is the base for translation. maybe the circuit+name fields were accidentially exchanged in the de files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable names are taked 1:1 from the official Brink translations in the Brink Service Tool. The comments are the variables names from the C# code of the tool for easier refenrecing. If you believe the comments are not helpful, I can drop those.
Or am I missing the point of your concern @john30?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be the other way around, i.e. message names are expected to be identical in both languages for one message whereas comments are expected to be different.
e.g. FanMode should have the de comment "Ventilatorbetrieb" and en "FanMode"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... my bad! To be honest I only studied the EN files (not the smartest decision in the hindsight), and for whatever reason blindly assumed this is the way to do it - I think the comments are not really used in Home Assistant, only the variable names, but for the sake of consistency I totally agree to make it consistent with the rest of the config files. Should be fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating that one.
is there any chance to export the comments in a decent fashion, i.e. "factory reset" instead of "FactoryReset" and "Rücksetzen auf Werkseinstellung" instead of "RücksetzenAufWerkseinstellung"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you get my comment @pvyleta ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john30 Thanks for the hint! I missed your last comment. I have removed the CamelCasing and now I use directly the strings from Brink Service Tool - it includes .
and (
)
Which I hope is fine - I can remove those if it would cause problems.
Any news on this? I received my EBUS interface, and the connection seems ok. Now all I need is support for Excellent300 heat recovery unit 🤞🤞🤞 |
@pvyleta Can you look at the changes John requested? I really hope this gets implemented soon 🤞 so I can start integrating it into my Homey :) |
r,,RHTSensorSensitivity,Empfindlichkeit Feuchtesensor,,,4050,33,,,SIR,,,,min,,SIR,,,[min:-2],max,,SIR,,,[max:2],step,,SIR,,,[step:1],default,,SIR,,,[default:0] | ||
w,,BacklightLevel,Beleuchtung Display,,,4080,1d,,,UIR,,%,[min:0;max:100;step:5;default:10] | ||
r,,BacklightLevel,Beleuchtung Display,,,4050,1d,,,UIR,,%,,min,,UIR,,%,[min:0],max,,UIR,,%,[max:100],step,,UIR,,%,[step:5],default,,UIR,,%,[default:10] | ||
w,,CO2Sensor1LowerLimit,CO2-Sensor 1, unterer Grenzwert,,,4080,34,,,UIR,,ppm,[min:400;max:2000;step:25;default:400] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with comma in comment, it needs to be put in double quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I haven't noticed this one. Thanks for noticing. I will fix those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john30 Fixed! 🙏
reworked and merged in c03dea8 |
@john30 Appreciate the effort you spent on cleaning this up! Thanks! |
Based on amazing work of Daniel Stringl, and then heavily extended by me, I believe it is worth to include these config files in the 'source-of-truth' repo, so that it is easily accessible for everyone.
The '3c' file tested on my Brink Renovent Sky 300, that has almost identical parameters (missing the display brightness). The contents are almost identical to '7c' for Renovent 400. The Brink HRUs unfortunately do not follow ebus specification correctly, so the identification is not an ASCII string, hence no IDENT is present, nor any HW/SW versions:
2024-03-03 14:53:09.058 [update notice] received scan-read scan.3c QQ=1f: ENCON; ;-;-
Therefore - only the CIRCUIT is in the name.
The files are based on the 'plus' version of the devices, in the latest SW. Older devices will have less parameters, but since Brink does not follow the ebus protocol, this is the best I can do with the current ebusd behavior.
For cofiguration for complete Brink HRU portfolio, head to my Brink HRU for ebusd repository. The files are not included here, since for other HRUs, the slave address is unknown. Once we learn those addresses through users of those units, we can one by one include them in here.
I have also added a CO2 sensor meter and a ZoneValve configsI found on the internet forums. They are untested, but since the original forum is not in English, this might help few people.