-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
So many changes #4
base: master
Are you sure you want to change the base?
Conversation
Also, modernize ns decls
Also, it was nice to meet you the other day. |
Sweet, I love the unicode renderer. That's awesome. Sorry I've been AFK on this for the last while -- I'll get my head above water with work stuff soon and then I'll be able to look at this closer. I really appreciate you sending this my way, and it will get in. |
I AM ONE DEGREE OF SEPARATION BETWEEN YOU TWO |
@joegallo bump - would be great to get this merged! |
bump :) @joegallo hi |
I like most of the ideas here. The unicode table is very nice! The main problem with depending on Cheshire specifically, is that it has quite a problematic dependency tree:
These jackson libs are used in many other libraries and their versions are not very well maintained, which often lead to dependency conflicts in bigger projects: Recently I've lost about a day because of this, before I finally found a workaround for my specific situation: The performance of I think it's important to leave the choice of the JSON codec to the consumers of this library somehow or simply don't provide JSON specific features in this core lib. For more background, here is a recent article, which compares the various Clojure JSON libs: https://www.juxt.pro/blog/json-in-clojure |
Looks good to me |
There's a fair bit here, and each commit is fairly self-explanatory, but just about every commit built on the last.
The high-level stuff: