Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart accepts now custom annotations for the Service #536

Merged
merged 2 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion k8s/helm-chart/redis-commander/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.3.1
version: 0.4.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 2 additions & 1 deletion k8s/helm-chart/redis-commander/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

A Helm chart for redis-commander

![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
![Version: 0.4.0](https://img.shields.io/badge/Version-0.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)

## Install

Expand Down Expand Up @@ -50,6 +50,7 @@ helm -n myspace install redis-web-ui ./k8s/helm-chart/redis-commander --set redi
| replicaCount | int | `1` | Number of replicas to create for deployment, should be 1 |
| resources | object | `{}` | We usually recommend not to specify default resources and to leave this as a conscious choice for the user. This also increases chances charts run on environments with little resources, such as Minikube. If you do want to specify resources, uncomment the following lines, adjust them as necessary, and remove the curly braces after 'resources:'. |
| securityContext | object | `{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"readOnlyRootFilesystem":false,"runAsNonRoot":true}` | Configuration of the linux security context for the docker image. This restricts the rights of the running docker image as far as possible. "readOnlyRootFilesystem" must be set to false to auto-generate a config file with multiple redis hosts or sentinel hosts |
| service.annotations | object | `{}` | Add additional annotations for the service spec Example: 'my.custom.annotation: value' |
| service.port | int | `80` | External port where service is available |
| service.type | string | `"ClusterIP"` | Type of k8s service to export |
| serviceAccount.annotations | object | `{}` | Annotations to add to the service account |
Expand Down
4 changes: 4 additions & 0 deletions k8s/helm-chart/redis-commander/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ metadata:
name: {{ include "redis-commander.fullname" . }}
labels:
{{- include "redis-commander.labels" . | nindent 4 }}
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
3 changes: 3 additions & 0 deletions k8s/helm-chart/redis-commander/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@
},
"type": {
"type": "string"
},
"annotations": {
"type": "object"
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions k8s/helm-chart/redis-commander/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ service:
type: ClusterIP
# -- External port where service is available
port: 80
# -- Add additional annotations for the service spec
# Example:
# 'my.custom.annotation: value'
annotations: {}
# my.custom.annotation: value

ingress:
# -- Enable Ingress for the service
Expand Down
Loading