Fixes modified: octoprint_tplinksmartplug/__init__.py #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/actions/stale-8
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/actions/stale-9 Bump actions/stale from 8 to 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull-request addresses and fixes several bugs/feature enhancements.
Specifically,
timestampcolumn fixed to be of typeDATETIMErather thanTXT[BUG]: sqlite3 schema type for 'timestamp' is 'TEXT' but should be 'DATETIME' #346grandtotaladded to calculate corrected total net of restarts inttotalcolumn [Feature Request]: Add additional field to database representing "corrected" total energy usage #344energy_data.dbare only added if:totalchanged, currentpower> 0 or has changed (this captures return to zero) [Feature Request]: Only add entries to db if current or power non-zero or if total changes #345The code covers the following 3 situations:
energy_data.dbcreation (one-time)energy_data.db(one-time to be consistent with above)Note that I was maximally "liberal" in retaining rows that have information - the only rows discarded are rows with zero
powerand no changes intotalor that are not the first return to zeropower(the final element is included so that you know when power shuts off)The GUI now reflects 'grandtotal' by passing that value to the javascript routines.
Let me know if you have any questions or concerns with any of the individual code changes.