feat(visitors): Fires events for received visitors message promotion … #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request/response.
damencho
force-pushed
the
visitors-promotion
branch
from
4f765b7 to
ce766a5
Compare
bgrozev
reviewed
Nov 30, 2023
modules/xmpp/strophe.emuc.js
Outdated
| CONNECTION_REDIRECTED, undefined, visitors.attr('focusjid'), response.attr('username')); | ||
| if (visitors.length && response.length) { | ||
| if (String(response.attr('allow')).toLowerCase() === 'true') { | ||
| logger.warn('Redirected back to main room.'); |
There was a problem hiding this comment.
Would it be clearer to log "promotion request accepted" and add a similar message when it's rejected?
bgrozev
previously approved these changes
Nov 30, 2023
bgrozev
approved these changes
Dec 4, 2023
hristoterezov
approved these changes
Dec 11, 2023
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
subhamcyara
pushed a commit
to subhamcyara/lib-jitsi-meet
that referenced
this pull request
Jul 19, 2024
jitsi#2403) * feat(visitors): Fires events for received visitors message promotion request/response. * squash: Updates logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…request/response.