Expects ljm to detect transcriptions on and off #15164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops potential transcribers and hidden participant actions and handling. Expect ljm to detect transcriptions on and off.
damencho
changed the title
damencho
changed the title
| _TRANSCRIBER_JOINED, | ||
| _TRANSCRIBER_LEFT | ||
| TRANSCRIBER_LEFT, | ||
| _TRANSCRIBER_JOINED |
There was a problem hiding this comment.
I know this is has been define like this before but it would be nice if remove the _
hristoterezov
previously approved these changes
Oct 2, 2024
hristoterezov
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where transcriber being kicked or disconnects will not be handled.
Fixes issue where an error received when sending rayo dial IQ will leave state as requesting subtitles.
jitsi/lib-jitsi-meet#2581