feat: add Python official Logging rotating handlers support (#6167)

jina-ai · Jul 9, 2024 · 58e0397 · 58e0397
1 parent 53ec704
commit 58e0397
Showing 1 changed file with 22 additions and 1 deletion.
diff --git a/jina/logging/logger.py b/jina/logging/logger.py
@@ -108,7 +108,7 @@ class JinaLogger:
     :return:: an executor object.
     """
 
-    supported = {'FileHandler', 'StreamHandler', 'SysLogHandler', 'RichHandler'}
+    supported = {'FileHandler', 'StreamHandler', 'SysLogHandler', 'RichHandler', 'TimedRotatingFileHandler', 'RotatingFileHandler'}
 
     def __init__(
         self,
@@ -246,6 +246,27 @@ def add_handlers(self, config_path: Optional[str] = None, **kwargs):
                 handler = logging.FileHandler(filename, delay=True)
                 handler.setFormatter(fmt(cfg['format'].format_map(kwargs)))
 
+            elif h == 'TimedRotatingFileHandler':
+                filename = cfg['filename'].format_map(kwargs)
+                handler = logging.handlers.TimedRotatingFileHandler(
+                    filename=filename,
+                    when=cfg['when'],
+                    interval=cfg['interval'],
+                    backupCount=cfg['backupCount'],
+                    encoding=cfg.get('encoding', 'utf-8')
+                )
+                handler.setFormatter(fmt(cfg['format'].format_map(kwargs)))
+
+            elif h == 'RotatingFileHandler':
+                filename = cfg['filename'].format_map(kwargs)
+                handler = logging.handlers.RotatingFileHandler(
+                    filename=filename,
+                    maxBytes=cfg['maxBytes'],
+                    backupCount=cfg['backupCount'],
+                    encoding=cfg.get('encoding', 'utf-8')
+                )
+                handler.setFormatter(fmt(cfg['format'].format_map(kwargs)))
+
             if handler:
                 self.logger.addHandler(handler)