Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issued #19 #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed Issued #19 #20

wants to merge 4 commits into from

Conversation

adalbertobrant
Copy link

Sending this minor fix to you , happy a nice Hacktoberfest 2020

@adalbertobrant
Update index.tsx
c85dc78 
Hi my friend, happy hacktoberfest 2020.
Just fixing a minor warning about some "variables" never used.
when doing some yarn start at web directory.
Enclosed is the warning 
./src/components/Input/index.tsx
  Line 19:36:  'error' is assigned a value but never used  @typescript-eslint/no-unused-vars

./src/pages/Home/index.tsx
  Line 1:27:  'useEffect' is defined but never used  @typescript-eslint/no-unused-vars

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
@adalbertobrant
Merge pull request #1 from adalbertobrant/adalbertobrant-patch-1
621183b 
Update index.tsx
@adalbertobrant
Upadte index.tsx
9bf0247 
Issue jhonatasmatos#19 now it is 100% fixed.
Have a nice Hacktoberfest 2020
@adalbertobrant
Merge pull request #2 from adalbertobrant/adalbertobrant-patch-2
2da6582 
Upadte index.tsx
@adalbertobrant
Copy link
Author

Just minor adjustment and the final minor fix.

Sorry about this trouble my friend.

Happy Hacktoberfest 2020

@jhonatasmatos
Copy link
Owner

Hello @adalbertobrant , how r u ?
Thank u for your PR, but I didn't understand yours commit, I couldn't see where you changed.
There are some comments about eslint, would it be this?

@adalbertobrant
Copy link
Author

Hello @adalbertobrant , how r u ?
Thank u for your PR, but I didn't understand yours commit, I couldn't see where you changed.
There are some comments about eslint, would it be this?

Hi Jhonatas Matos, that is it . I opened and issue in the issues sections, it is not a bug , just a minor modification to remove the warning message. If you accepet this merge please put hacktoberfest-accepeted. In the import and in the fuction the variables was not in use, so to avoid the warning message I study the case ( I am new at javascript) and decide that in the terminal your code should not have warnings to be more beautiful. In the issue section I send to you some pics. The issue is masked as #19

@jhonatasmatos
Copy link
Owner

Hello @adalbertobrant , how r u ?
Thank u for your PR, but I didn't understand yours commit, I couldn't see where you changed.
There are some comments about eslint, would it be this?

Hi Jhonatas Matos, that is it . I opened and issue in the issues sections, it is not a bug , just a minor modification to remove the warning message. If you accepet this merge please put hacktoberfest-accepeted. In the import and in the fuction the variables was not in use, so to avoid the warning message I study the case ( I am new at javascript) and decide that in the terminal your code should not have warnings to be more beautiful. In the issue section I send to you some pics. The issue is masked as #19

aaah ok ! Now I understood . Thank u very much your issue !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adalbertobrant @jhonatasmatos