Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementations for new API: config profile with repository context #1057

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Add implementations for new API: config profile with repository context #1057

merged 2 commits into from
Dec 16, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Dec 16, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This Pr introduces a new endpoint service that gets a configuration profile by repo URL.
The former "GetConfigProfile" service was changed to "GetProfileByName"
tests were added + initXscTest func was altered to better check Xsc endpoints after Xsc migration to Xray

This PR is a recreation of: #1054

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@eranturgeman eranturgeman requested review from attiasas and orz25 and removed request for attiasas and orz25 December 16, 2024 12:22
attiasas
attiasas reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!, checkout my comments

tests/xsc_test.go Outdated Show resolved Hide resolved
tests/xsc_test.go Outdated Show resolved Hide resolved
xsc/manager.go Outdated Show resolved Hide resolved
xsc/services/profile.go Outdated Show resolved Hide resolved
xsc/services/profile.go Outdated Show resolved Hide resolved
xsc/services/profile.go Outdated Show resolved Hide resolved
xsc/services/profile.go Outdated Show resolved Hide resolved
tests/xscconfigprofile_test.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@eyalbe4 eyalbe4 merged commit 80abb8e into jfrog:dev Dec 16, 2024
23 of 24 checks passed
This was referenced Dec 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eranturgeman @attiasas @eyalbe4