Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate artifactory commands #2828

Open
wants to merge 3 commits into
base: migrate-artifactory-commands
Choose a base branch
from

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Jan 13, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on:
jfrog/jfrog-cli-core#1334
jfrog/jfrog-cli-artifactory#34
jfrog/jfrog-cli-security#293

@bhanurp bhanurp changed the title Migrate artifactory commands WIP: Migrate artifactory commands Jan 13, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@bhanurp bhanurp force-pushed the migrate-artifactory-commands branch from 6dc2b78 to 13dc47e Compare January 23, 2025 06:20
@bhanurp bhanurp changed the title WIP: Migrate artifactory commands Migrate artifactory commands Jan 23, 2025
@EyalDelarea EyalDelarea added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Jan 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 23, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 23, 2025

replace github.com/jfrog/jfrog-cli-artifactory => github.com/bhanurp/jfrog-cli-artifactory v0.1.12-0.20250123060215-b15168492ff0

replace github.com/jfrog/jfrog-cli-security => github.com/bhanurp/jfrog-cli-security v1.14.1-0.20250123044515-d8a14cb8bdb7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change in security repo?
I didn't see a pull request there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with artifactory commands moved to cli-artifactory, cli-security has to use cli-artifactory as dependency now. I will raise a PR on security as well need at least an initial review on cli-core and cli-artifactory PRs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the PR on cli-security jfrog/jfrog-cli-security#293

@bhanurp bhanurp requested a review from EyalDelarea January 23, 2025 07:58
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants