-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate artifactory commands #2828
base: migrate-artifactory-commands
Are you sure you want to change the base?
Migrate artifactory commands #2828
Conversation
6dc2b78
to
13dc47e
Compare
|
||
replace github.com/jfrog/jfrog-cli-artifactory => github.com/bhanurp/jfrog-cli-artifactory v0.1.12-0.20250123060215-b15168492ff0 | ||
|
||
replace github.com/jfrog/jfrog-cli-security => github.com/bhanurp/jfrog-cli-security v1.14.1-0.20250123044515-d8a14cb8bdb7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change in security repo?
I didn't see a pull request there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with artifactory commands moved to cli-artifactory, cli-security has to use cli-artifactory as dependency now. I will raise a PR on security as well need at least an initial review on cli-core and cli-artifactory PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the PR on cli-security jfrog/jfrog-cli-security#293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev
branch.go vet ./...
.go fmt ./...
.Depends on:
jfrog/jfrog-cli-core#1334
jfrog/jfrog-cli-artifactory#34
jfrog/jfrog-cli-security#293