-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out non-applicable violations if requested by policy #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded the new parsed violations results to ApplicabilityScanManager.
…ew parsed violations results to IacScanManager.
…new parsed violations results to SastScanManager.
…e new parsed violations results to SecretScanManager.
…ded relevant logs
…methods for hte new struct
…o jas-violations-support
…canner cannot incur violations
…y commented at this point)
…o delete comments in results.go)
…rseCommandResults related to jas violations
…esults) + changed the names for Sca parsing methods
…all relevant references
…all relevant references
eranturgeman
had a problem deploying
to
frogbot
December 2, 2024 16:09 — with
GitHub Actions
Failure
…man/jfrog-cli-security into skip-not-applicable-cves
eranturgeman
had a problem deploying
to
frogbot
December 3, 2024 15:52 — with
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
December 3, 2024 15:54 — with
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
December 3, 2024 15:56 — with
GitHub Actions
Failure
…man/jfrog-cli-security into skip-not-applicable-cves # Conflicts: # go.mod # go.sum # utils/results/common.go
7 tasks
eranturgeman
had a problem deploying
to
frogbot
December 4, 2024 14:46 — with
GitHub Actions
Failure
…man/jfrog-cli-security into skip-not-applicable-cves
eranturgeman
had a problem deploying
to
frogbot
December 4, 2024 14:47 — with
GitHub Actions
Failure
eranturgeman
changed the title
Filter out non-applicable violations if requested bu policy
Filter out non-applicable violations if requested bט policy
Jan 2, 2025
eranturgeman
changed the title
Filter out non-applicable violations if requested bט policy
Filter out non-applicable violations if requested by policy
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This Pr introduces an additional filtering to found violations:
If a violation is non-applicable AND the policy that initiated the violation is set to "skip non applicable" - the violation will not appear in the final results (audit, scan, frogbot)
This PR includes changes from this PR #241 that needs to be merged prior to this one
This PR depends on: jfrog/jfrog-client-go#1052