Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup command improvements #36

Merged
merged 13 commits into from
Jan 30, 2025
Merged

Setup command improvements #36

merged 13 commits into from
Jan 30, 2025

Conversation

sverdlov93
Copy link
Collaborator

@sverdlov93 sverdlov93 commented Jan 28, 2025 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Added maven
Improved nuget and dotnet code

@sverdlov93 sverdlov93 changed the title setup command improvments Setup command improvements Jan 28, 2025
@sverdlov93 sverdlov93 requested a review from omerzi January 28, 2025 16:27
omerzi
omerzi reviewed Jan 29, 2025
View reviewed changes
artifactory/commands/setup/setup.go Show resolved Hide resolved
artifactory/commands/setup/setup.go Show resolved Hide resolved
artifactory/commands/setup/setup_test.go Outdated Show resolved Hide resolved
artifactory/commands/setup/setup_test.go Show resolved Hide resolved
@sverdlov93 sverdlov93 merged commit c49fc23 into jfrog:main Jan 30, 2025
9 checks passed
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @omerzi