Move Jest and ESLint to peerDependencies #55
Conversation
| @@ -47,6 +47,10 @@ | |||
| "prettier": "^1.14.3", | |||
| "rimraf": "^2.6.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "eslint": "^4.0.0 || ^5.0.0", | |||
There was a problem hiding this comment.
can you remove eslint from dependencies with this change? Also, remove https://github.com/jest-community/jest-runner-eslint/blob/master/src/utils/getLocalESLint.js?
There was a problem hiding this comment.
Right, I just moved it to devDeps...
I guess https://github.com/jest-community/jest-runner-eslint/blob/master/src/utils/getLocalESLint.js now just becomes a regular require('eslint') right?
There was a problem hiding this comment.
It can be both a dep and a peer dep, or a peer and a dev - in either case it will do what you expect. The difference, though, is that if it’s a dep + peer, then it might not be a breaking change to add the peer - if it’s a peer+dev, then it definitely is breaking.
There was a problem hiding this comment.
@ljharb thanks, you are great!
There was a problem hiding this comment.
when it's in dependencies now, we will always require our own, and never the user's. Which means that this now moves from eslint 4 to eslint 5, which is a breaking change either way.
I suppose we could roll back to eslint v4, but we really should allow people to use eslint v5 with this plugin
There was a problem hiding this comment.
Not when it's also in peer dependencies - if the user specifies eslint 4, then we won't install v5, we'll prefer their v4.
rogeliog
changed the title
rogeliog
changed the title
SimenB
changed the title
package.json
Outdated
| @@ -26,7 +26,6 @@ | |||
| "chalk": "^2.4.1", | |||
| "cosmiconfig": "^5.0.0", | |||
| "create-jest-runner": "^0.4.1", | |||
| "eslint": "^5.6.0", | |||
| "find-up": "^3.0.0" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
no, I mean find-up 🙂 That's not used anymore
package.json
Outdated
| @@ -47,6 +47,10 @@ | |||
| "prettier": "^1.14.3", | |||
| "rimraf": "^2.6.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "eslint": "^4.0.0 || ^5.0.0", | |||
| "jest": ">=21.0.0" | |||
There was a problem hiding this comment.
this should be ^21 || ^22 || ^23 since we cant know if it works with v24 yet.
Fixes #54
I kept the Jest version at 21 given that the runner works well with Jest 21 and Jest 23 is only needed for the watch plugin. I added the appropriate error for when the user tries to use the watch plugin with an insufficient version of Jest.