fix: use useRef for Host queue to improve stability #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this library to build "overlay" widgets in our RN project, we discovered that some
Portal
s did not unmount correctly.For instance, our react-navigation based project has
ScreenA
containingOverlayA
, which are implemented withPortal
. WhenScreenA
is popped, we found that sometimesOverlayA
is not unmounted, out of our expectation.After some digging, it seems that the
queue
array inHost
component might be one of the problem: sinceHost
is a functional component,queue
is re-initialized each timeHost
re-renders. According to the original implementation,queue
is a class member, so it should become aRefObject
after converting to functional component.I utilized
patch-package
to create a hotfix for my project and the behavior becomes expected, so I created this PR to address the problem. This PR rewritesqueue
into aRefObject
withuseRef
as well as extracts type definition ofqueue
intoIPortalAction
.