Fixing 'no violations found' file links on Windows (Issue #50) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention this is only an issue if your files are located within subfolders and your Jenkins is running on Windows. I confirmed it was still an issue in the latest snapshot and this change fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix as described in issue 50. I ran across the issue on Jenkins running on Windows server. The problem is that all the file keys in the FileModelProxy use the file separator for the system (*nix='/', windows=''), but the
String namehere comes fromgetRestOfPath()which prefers the url forward slash (which doesn't work for the Windows keys). To transform the "rest of path" to the true file key, we must convert any '/' in the name to the File.separator for the system.