[JENKINS-27650] TCB plugin performance (extra caching) #28
Conversation
The approach is not ready.
| @@ -158,7 +233,7 @@ else if (tjp.getThrottleOption().equals("category")) { | |||
| int totalRunCount = 0; | |||
|
|
|||
| for (AbstractProject<?,?> catProj : categoryProjects) { | |||
| if (Hudson.getInstance().getQueue().isPending(catProj)) { | |||
| if (checkPending && Hudson.getInstance().getQueue().isPending(catProj)) { | |||
There was a problem hiding this comment.
It was a bad idea from another commit. I'll rework it
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>matrix-project</artifactId> | ||
| <version>1.0</version> | ||
| <type>jar</type> |
|
Merging with #27 will be hard. Probably you could just merge the first three commits, but the fourth ( This seems risky: code mistakes or oversights could easily lead to a stale cache. |
Yes, I'm also aware about it. I consider flushing the cache on updates and other conditions. There's still a risk of false-negatives deadlock if something is implemented incorrectly. Probably, a periodic cache cleanup (e.g. every 1 minute) could prevent it |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
oleg-nenashev
changed the title
jglick
changed the title
|
@oleg-nenashev The last update to this PR was 4 years ago. Can this PR be closed to clean up the open pull requests list? |
The approach is not ready (see the idea in #27 ).
Merge with #27 is also required