JENKINS-23368 - Enforce start interval/delay between running builds. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins » throttle-concurrent-builds-plugin #37 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I'd love this feature too. Is this PR still being reviewed/considered? |
| @@ -57,10 +58,12 @@ public ThrottleJobProperty(Integer maxConcurrentPerNode, | |||
| List<String> categories, | |||
| boolean throttleEnabled, | |||
| String throttleOption, | |||
| @CheckForNull ThrottleMatrixProjectOptions matrixOptions | |||
| @CheckForNull ThrottleMatrixProjectOptions matrixOptions, | |||
| Long startInterval | |||
There was a problem hiding this comment.
An old constructor is also required for the backward compatibility
|
The change would be useful. |
Closed
|
The pull request needs some polishing for the initialization flows. Now it stores null till the first getter invocation. readResolve() would be helpful. I'm also aware about exposing Long to the external interface. |
| Run<?,?> lastBuild = p.getLastBuild(); | ||
| if (null != lastBuild && lastBuild.isBuilding()) { | ||
|
|
||
| // Probably better to use lastBuild.getStartTimeInMillis() which was introduced in Jenkins 1.494. |
There was a problem hiding this comment.
The core dependency has been bumped, hence it can be updated now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is to enable a configurable interval/delay between start of concurrent builds for a project.
More detail of available in Jira: https://issues.jenkins-ci.org/browse/JENKINS-23368
feedback and questions welcome
thanks
Geoff