[JENKINS-74031] [JENKINS-74847] Migrate legacy checkUrl attributes in org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly

[shlomomdahan]

JENKINS-74031
JENKINS-74847

Problem:

• Regression in recently merged PR [JENKINS-74031] Migrate legacy checkUrl attributes in SSHBuildWrapper/global.jelly #25 which was reverted in Revert "[JENKINS-74031] Migrate legacy checkUrl attributes in SSHBuildWrapper/global.jelly" #30
• Issue was that Hostname and Credentials ID were empty after saving the System config page and revisiting the SSH remote hosts option.
• This issue was created because we removed the value field, and the test case was missed in which we save, submit, and refresh the form to check if values persist.

Solution

• Add back the value field to the respective entires.

Testing done

1. Tested by entering relevant fields and saving form, refreshing page and verifying values persist.
2. Tested with CSP restrictive enabled to ensure there are no further regressions.

Before Changes
Regression
After Changes with CSP Restrictive

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Thanks for the PR! Testing looks good.

Diff from original attempt:

--- /tmp/global.jelly   2024-11-14 06:50:07.082934928 -0800
+++ src/main/resources/org/jvnet/hudson/plugins/SSHBuildWrapper/global.jelly    2024-11-14 06:50:36.478897814 -0800
@@ -7,14 +7,14 @@
       <f:repeatable var="site" name="sites" items="${descriptor.sites}">
         <table width="100%">
           <f:entry title="${%Hostname}" field="hostname" help="/plugin/ssh/help-hostname.html">
-            <f:textbox/>
+            <f:textbox value="${site.hostname}"/>
           </f:entry>
           <f:entry title="${%Port}" help="/plugin/ssh/help-port.html">
             <f:textbox name="port" value="${site.port}"/>
           </f:entry>
 
           <f:entry title="${%Credentials}" field="credentialId">
-            <c:select/>
+            <c:select value="${site.credentialId}"/>
           </f:entry>
 
           <f:entry title="${%Pty}" help="/plugin/ssh/help-pty.html">