Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for MultiBucketStrategy class #432

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

yashpal2104
Copy link
Contributor

@yashpal2104 yashpal2104 commented Jan 4, 2025

Testing done

Add test for MultiBucketStrategy class and Made getStrategy method package-protected and condition for non-integer input.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@yashpal2104 yashpal2104 requested a review from a team as a code owner January 4, 2025 18:57
@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 4, 2025
@yashpal2104
Copy link
Contributor Author

Should I replace the numbers with the variable I have declared DEFAULT _PRIORITIES_NUMBER and DEFAULT_PRIORITY for improved readability and clean code?

@MarkEWaite
Copy link
Contributor

Should I replace the numbers with the variable I have declared DEFAULT _PRIORITIES_NUMBER and DEFAULT_PRIORITY for improved readability and clean code?

Thanks for asking a very, very good question. When I reviewed the code the first time, I didn't consider your question. A second review in the context of your question made the test code clearer for me. Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) January 7, 2025 01:34
@MarkEWaite MarkEWaite merged commit b91ea54 into jenkinsci:master Jan 7, 2025
17 of 18 checks passed
@yashpal2104 yashpal2104 deleted the multiBucketStrategyTest branch January 7, 2025 07:16
@yashpal2104 yashpal2104 restored the multiBucketStrategyTest branch January 7, 2025 14:28
@yashpal2104 yashpal2104 deleted the multiBucketStrategyTest branch January 7, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants