Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require TestRunListener.init() before use #425

Merged

Conversation

MarkEWaite
Copy link
Contributor

Do not require TestRunListener.init() before use

New tests do not need to initialize the test run listener

Testing done

Confirmed that existing tests pass and new tests no longer report a null pointer exception to the log.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

New tests do not need to initialize the test run listener
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Dec 28, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 28, 2024 18:46
@MarkEWaite MarkEWaite merged commit 31acb9d into jenkinsci:master Dec 28, 2024
18 checks passed
@MarkEWaite MarkEWaite deleted the adapt-TestRunListener-to-more-tests branch December 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant