Fix job priorities loading #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cytrek-betoniarek
force-pushed
the
fixing-the-scale-method
branch
2 times, most recently
from
41a6c60 to
ec0c0dd
Compare
cytrek-betoniarek
force-pushed
the
fixing-the-scale-method
branch
4 times, most recently
from
02da14e to
90a5bc0
Compare
cytrek-betoniarek
force-pushed
the
fixing-the-scale-method
branch
from
90a5bc0 to
5c58c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
I added a test for a case where the scale method from PriorityCalculationsUtil function returned
undesired values on my system, but it didn't fail in the check here. Thus I tested this method on my another device and it worked also there. Since the issue seems to be dependent on hardware I removed added test, and just fixed the scale method.
This PR refers to this bug.