Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checkstyle for Java 11 #154

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

MarkEWaite
Copy link
Contributor

Enable checkstyle for Java 11

Java 11 has been required since the plugin first required Jenkins 2.361 or later. If we're going to use checkstyle, let's use the most recent checkstyle release.

What has been done

  1. Confirmed that checkstyle output is silent in a typical build
  2. Will confirm that ci.jenkins.io checkstyle output is also silent

How to test

  1. Review checkstyle output on ci.jenkins.io

No automated tests because this is static analysis performed at build time.

Checklist

  • Git commits follow best practices
  • Build passes in Jenkins
  • Appropriate tests or explanation to why this change has no tests
  • Pull Request is marked with appropriate label (see .github/release-drafter.yml)
  • JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
  • For dependency updates: links to external changelogs and, if possible, full diffs

Java 11 has been required since the plugin first required Jenkins 2.361
or later.  If we're going to use checkstyle, let's use the most recent
checkstyle release.
@MarkEWaite MarkEWaite added the chore General project maintenance label Jan 5, 2025
@MarkEWaite MarkEWaite merged commit 25d7048 into jenkinsci:master Jan 5, 2025
16 checks passed
@MarkEWaite MarkEWaite deleted the enable-latest-checkstyle branch January 5, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant