Skip to content

Commit

Permalink
Replace outdated icons with analytics symbol (#156)
Browse files Browse the repository at this point in the history
https://weekly.ci.jenkins.io/design-library/symbols/ shows the preferred
images for Jenkins icons.  The symbols scale better and look more
consistent with the rest of Jenkins.

I chose "analytics" from the available symbols listed at
https://github.com/jenkinsci/jenkins/tree/master/war/src/main/resources/images/symbols

I added the page-headline class to the h1 headings because that seems
to be a class that is used in other page headlines.

Testing done:

* Confirmed that images were displayed as expected in freestyle projects
  and in matrix projects
  • Loading branch information
MarkEWaite authored Jan 5, 2025
1 parent cae313a commit e862949
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/main/java/hudson/plugins/plot/MatrixPlotAction.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public String getDisplayName() {
}

public String getIconFileName() {
return "graph.png";
return "symbol-analytics";

Check warning on line 69 in src/main/java/hudson/plugins/plot/MatrixPlotAction.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 69 is not covered by tests
}

public String getUrlName() {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/hudson/plugins/plot/PlotAction.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public PlotAction(Job<?, ?> job, List<Plot> plots) {

@Override
public String getIconFileName() {
return "graph.png";
return "symbol-analytics";

Check warning on line 42 in src/main/java/hudson/plugins/plot/PlotAction.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 42 is not covered by tests
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<l:layout title="${it.project.displayName} plots">
<st:include it="${it.project}" page="sidepanel.jelly" />
<l:main-panel>
<h1>${%Plot Groups}</h1>
<h1 class="page-headline">${%Plot Groups}</h1>

<j:choose>
<j:when test="${it.hasPlots()}">
Expand All @@ -18,7 +18,7 @@
</p>
<table>
<j:forEach var="group" items="${it.originalGroups}">
<t:summary icon="icon-graph icon-md" href="${it.getUrlGroup(group)}/">
<t:summary icon="symbol-analytics icon-md" href="${it.getUrlGroup(group)}/">
${group}
</t:summary>
</j:forEach>
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/hudson/plugins/plot/PlotAction/index.jelly
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<l:layout title="${it.job.displayName} plots">
<st:include it="${it.job}" page="sidepanel.jelly" />
<l:main-panel>
<h1>${%Plot Groups}</h1>
<h1 class="page-headline">${%Plot Groups}</h1>

<j:choose>
<j:when test="${it.hasPlots()}">
Expand All @@ -18,7 +18,7 @@
</p>
<table>
<j:forEach var="group" items="${it.originalGroups}">
<t:summary icon="icon-graph icon-md" href="${it.getUrlGroup(group)}/">
<t:summary icon="symbol-analytics icon-md" href="${it.getUrlGroup(group)}/">
${group}
</t:summary>
</j:forEach>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<l:layout title="${it.group}">
<st:include it="${it.job}" page="sidepanel.jelly" optional="true" />
<l:main-panel>
<h1><l:icon class="icon-graph icon-xlg"/>${it.group}</h1>
<h1 class="page-headline"><l:icon class="symbol-analytics icon-xlg"/> ${it.group}</h1>
<div>
<st:adjunct includes="hudson.plugins.plot.PlotReport.jump-to-plot" />
${%Jump to} <select class="plot-selector" name="choice">
Expand Down

0 comments on commit e862949

Please sign in to comment.