Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All executor feature. #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

All executor feature. #4

wants to merge 13 commits into from

Conversation

jrpalmer
Copy link

Proposing a small feature that will dynamically set weight to the number of executors. Example: I wanted to be able to use a templated build job that can run on any node, with any number of executors. When this particular job builds it can be on the only thing building as it does cleanup that would cause any other build to fail. This plug in worked great, until I had nodes with different number of executors. Take a look, let me know if anything needs correcting.

@buildhive
Copy link

Jenkins » heavy-job-plugin #10 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Jenkins » heavy-job-plugin #11 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

Jenkins » heavy-job-plugin #12 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@RavisMsk
Copy link

Is there any progress with this pull request?
This feature is crucial in cases, when there are some jobs, that can monopolise some resource/tools (e.g., xcodebuild), but cluster has nodes with different amount of executors.

@jrpalmer
Copy link
Author

@RavisMsk We've been using this version of the plugin for 2 years now and has been working good. I haven't dusted off this project in awhile though.

@RavisMsk
Copy link

@jrpalmer Is there a way to install your fixed version? Using ".hpi"?
Thanks for response!

@jrpalmer
Copy link
Author

@RavisMsk Yeah, just pull down my PR and build it. It will generate an HPI and you can just install it. Let me know how it goes! Feel free to contribute if you find anything!

@jrpalmer
Copy link
Author

Known issue - If the same build executes on different nodes where the executor counts are not the same, an issue can occur when the build stays in the queue for a long time. It appears that the job weight is incorrect. It's intermittent, but you may notice a build hanging around waiting for executors when they are all open. I believe the issue is in the getExecutors method. When I get some free time, I'll fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants