-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All executor feature. #4
base: master
Are you sure you want to change the base?
Conversation
…handle the case when I only want one build occuring at a given time.
time. For now, I just return the estimated duration as 0. Will investigate what to pass later on.
now uses the label that the build is restricted too to get the node executors. If it can't get the labels, then it defaults to using the Job Weight.
checked in case I need to default it.
Jenkins » heavy-job-plugin #10 SUCCESS |
Jenkins » heavy-job-plugin #11 SUCCESS |
Jenkins » heavy-job-plugin #12 SUCCESS |
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Is there any progress with this pull request? |
@RavisMsk We've been using this version of the plugin for 2 years now and has been working good. I haven't dusted off this project in awhile though. |
@jrpalmer Is there a way to install your fixed version? Using ".hpi"? |
@RavisMsk Yeah, just pull down my PR and build it. It will generate an HPI and you can just install it. Let me know how it goes! Feel free to contribute if you find anything! |
Known issue - If the same build executes on different nodes where the executor counts are not the same, an issue can occur when the build stays in the queue for a long time. It appears that the job weight is incorrect. It's intermittent, but you may notice a build hanging around waiting for executors when they are all open. I believe the issue is in the getExecutors method. When I get some free time, I'll fix this. |
Proposing a small feature that will dynamically set weight to the number of executors. Example: I wanted to be able to use a templated build job that can run on any node, with any number of executors. When this particular job builds it can be on the only thing building as it does cleanup that would cause any other build to fail. This plug in worked great, until I had nodes with different number of executors. Take a look, let me know if anything needs correcting.