Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -parameters for JavaCompile tasks #234

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

alextu
Copy link

@alextu alextu commented Oct 28, 2024

See jenkinsci/plugin-pom#415

Sets the -parameters option to javac, aligning with plugins built with maven-hpi-plugin.

Testing done

  • Unit test included
  • Manually tested: built gradle-plugin with a dev version of gradle-jpi-plugin, ensured that the o.k.s.BytecodeReadingParanamer#lookupParameterNames: Looking up parameter names for public hudson.util.FormValidation hudson.plugins.gradle.enriched.EnrichedSummaryConfig.doCheckHttpClientTimeoutInSeconds(int); update plugin to a version created with a newer harness are gone

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alextu
Copy link
Author

alextu commented Oct 30, 2024

@sghill Would you be able to take a look?

@sghill sghill merged commit 8734f23 into jenkinsci:master Nov 23, 2024
14 checks passed
@sghill
Copy link

sghill commented Dec 7, 2024

@alextu can you try out 0.52.0-rc.2 and let me know if it's working as expected?

@alextu
Copy link
Author

alextu commented Dec 9, 2024

@alextu can you try out 0.52.0-rc.2 and let me know if it's working as expected?

Thanks, it seems to work fine: I compiled gradle-plugin with this jpi version, no more warnings in logs 👍

@sghill
Copy link

sghill commented Dec 9, 2024

@alextu thanks, v0.52.0 has been released

@alextu alextu deleted the atual/javac branch December 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants