-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger on deploy status and periodically #1563
Conversation
[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated. |
aad8df3
to
1d759c6
Compare
29ed582
to
f98d820
Compare
Tests require jenkins-x/go-scm#404 to be merged |
e0b6f63
to
77befee
Compare
@msvticket how we getting on with this? Need an assist or anything? |
I still have some unit tests to implement. Some tests for periodics are implemented, but none for deployment. Also I haven't done any manual tests yet. Some documentation would be generated automatically, but some more should be written I guess. So you could work on tests and docs... But I'll get to it eventually. |
Failed to merge this PR due to:
|
4 similar comments
Failed to merge this PR due to:
|
Failed to merge this PR due to:
|
Failed to merge this PR due to:
|
Failed to merge this PR due to:
|
a lighthousejob gets a unique name (using generateName) so needs to get it to update status
need to protect .git-credentials from test that is erasing password
6138ddf
to
12192a8
Compare
No description provided.