Add all artifacts to maintainers and issue lists when wildcard is used #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
changed the title
timja
approved these changes
Sep 29, 2024
daniel-beck
reviewed
Sep 30, 2024
Comment on lines
+205
to
+206
| if (lastPathElement.endsWith("-releaseblocker") || lastPathElement.endsWith("-releaseblock")) { | ||
| LOGGER.log(Level.INFO, "Release blocked for artifact ID: " + artifactId) |
There was a problem hiding this comment.
Rather than add special handling for a weakly adhered to naming convention, if we add code for this case, it should just be a new attribute.
|
|
||
| if (maintainersByComponent.containsKey(key)) { | ||
| LOGGER.log(Level.WARNING, "Duplicate maintainers entry for component: " + key) | ||
| if (lastPathElement.contains("*")) { |
There was a problem hiding this comment.
Seems unnecessarily complicated, because extraNames is expected to only exist with wildcard in the first place?
| @@ -358,6 +364,16 @@ class ArtifactoryPermissionsUpdater { | |||
| new File('checks-details.txt').text = details | |||
| } | |||
|
|
|||
| private static void addMaintainers(HashMap<String, List<String>> maintainersByComponent, String key, Definition definition) { | |||
| if (maintainersByComponent.containsKey(key)) { | |||
| LOGGER.log(Level.WARNING, "Duplicate maintainers entry for component: " + key) | |||
There was a problem hiding this comment.
Interestingly, we have some of these in the log. Anyone want to look into this?
Needs to be tested first. For some plugins that moved groupIds a few times we had to remove the old ones due to permission target length limitations at the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2911
Allows each component to define extra artifact names, those then inherit the same maintainers and issue tracker(s) as the parent component.
A more straightforward approach might be to just define
pathsexplicitly for each component without using *, but since the last element of path sometimes doesn't match the component name and the component name takes precedence, I decided to add a new field to Definition for defining the extra components.