Change colors of health checker results #1584
Conversation
| @@ -1,11 +1,13 @@ | |||
| import React, {useState} from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import {Progress, Tooltip} from 'reactstrap'; | |||
| import '../styles/progressbar.css'; | |||
There was a problem hiding this comment.
can you change this to a css module, so we don't introduce global styles with generic names?
|
|
||
| function PluginHealthScoreProgressBar({healthScore, name}) { | ||
| const score = healthScore.value || 0; | ||
| const color = | ||
| score > 80 ? 'success' : score > 60 ? 'warning' : 'danger'; | ||
| score >= 80 ? "first" : score >=60 && score <80 ? 'second' : score >=40 && score <60 ? 'third' |
There was a problem hiding this comment.
I'm not sure this needs to be css classes for a single style attribute change.
|
The referenced issue is about the health-score tab, which is not affected by this PR. Instead this changes the color of helth bars, which are already using reasonable colors. The current scheme seems logical (resembles traffic lights), the proposed one seems random. @AayushSaini101 I appreciate the effort, but I currently don't see this as an improvement. Contributions that would make the health-score tab (e.g. https://plugins.jenkins.io/slack/healthscore/ ) more colorful would be appreciated though! |
|
I agree we should close this. There is a |
Related: #1555
SuggestedColors and Range: