Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description formatting #1581

Closed
wants to merge 1 commit into from
Closed

Update description formatting #1581

wants to merge 1 commit into from

Conversation

AayushSaini101
Copy link

Related: #1580

@AayushSaini101 AayushSaini101 requested a review from a team as a code owner December 30, 2023 14:06
@zbynek
Copy link
Contributor

zbynek commented Dec 30, 2023

Thanks for the contribution.

As far as design goes, personally I'm not sure if this is an improvement 🤷 @alecharp do you have an opinion?

From the technical point of view, there should be an ul tag wrapping the lis.

@alecharp
Copy link
Contributor

alecharp commented Jan 8, 2024

I agree with @zbynek this doesn't look right. Have you tested your changes locally @AayushSaini101?

@alecharp
Copy link
Contributor

I think we should close this for now.

@zbynek zbynek closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AayushSaini101 @zbynek @alecharp @aayushRedHat