chore: use exponential delay when axios retries requests

[dduportal]

As mentionned by @slide and @uhafner in gitter/matrix channels, there has been issues with the https://plugins.jenkins.io/token-macro/ page not showing the proper readme page which is unexpected.

While searching for this, it appeared that there are a lot of network error on the node http.js client side like the following:

➤ YN0000: [@jenkins-cd/jenkins-plugin-site]: error error trying to fetch https://plugins.jenkins.io/api/plugin/kubernetes-credentials-provider 
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]: 
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]: 
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   AggregateError: 
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - AxiosError.js:89 Function.AxiosError.from
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     [website-jobs_plugin-site_master]/[axios]/lib/core/AxiosError.js:89:14
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - http.js:606 RedirectableRequest.handleRequestError
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     [website-jobs_plugin-site_master]/[axios]/lib/adapters/http.js:606:25
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - node:events:514 RedirectableRequest.emit
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:events:514:28
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - index.js:14 ClientRequest.eventHandlers.<computed>
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     [website-jobs_plugin-site_master]/[follow-redirects]/index.js:14:24
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - node:events:514 ClientRequest.emit
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:events:514:28
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - node:_http_client:495 TLSSocket.socketErrorListener
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:_http_client:495:9
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - node:events:514 TLSSocket.emit
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:events:514:28
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - destroy:151 emitErrorNT
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:internal/streams/destroy:151:8
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - destroy:116 emitErrorCloseNT
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:internal/streams/destroy:116:3
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:   - task_queues:82 processTicksAndRejections
➤ YN0000: [@jenkins-cd/jenkins-plugin-site]:     node:internal/process/task_queues:82:21

Even though there is a retry at 3, this PR is a short term fix to:

• Retry more often (5 times instead of 3 as pointed out by @lemeurherve ❤️ )
• Add an exponential backof for retries to let the HTTP client breathe a little (ref. https://www.npmjs.com/package/axios-retry/v/3.8.0)

[dduportal]

25:44  warning  Caution: `axiosRetry` also has a named export `exponentialDelay`. Check if you meant to write `import {exponentialDelay} from 'axios-retry'` instead  import/no-named-as-default-member`

WAT

[halkeye]

i think its just saying don't import the entire namespace when you just want one function.

import {exponentialDelay} from 'axios-retry';

is probably what you want

[dduportal]

i think its just saying don't import the entire namespace when you just want one function.

import {exponentialDelay} from 'axios-retry';

is probably what you want

Gotcha, also found github issues recommending the same. Thanks for the explanation: the linter wasn't really clear on why should I avoid the former one.

21eba5f should fix it, but it's initial build (number 3) ended in a test timeout => triggered a new build

[dduportal]

OK, there is a test reaching the 5s timeout. Make sense as I've added an exponential backoff.

Let's fix it. (but the fetch error are not present anymore on the past 3 builds)

[dduportal]

Self merging as the build passed. The goal is to ensure main branch is fixed on infra.ci as soon as possible (as admin of the controller)

Please feel free to rollback if it is a problem.