wip #1561
Closed
wip #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that'll do anything. What are you trying to fix? |
|
@halkeye yeah my change isn't even functional, closing this PR. I'm trying to get rid of this kind of error: jenkins-infra/helpdesk#3816 (comment) This error is too frequent, I find the fetch step of the build to be quite flaky, that was a tentative at avoiding it. |
halkeye
reviewed
Nov 22, 2023
| @@ -104,7 +104,7 @@ function PluginPageLayout({plugin, children}) { | |||
| <h5>Maintainers</h5> | |||
| <PluginDevelopers developers={plugin.developers} /> | |||
| </div> | |||
| {shouldShowWikiUrl(plugin.wiki) && | |||
| {shouldShowWikiUrl(plugin.wiki?) && | |||
There was a problem hiding this comment.
Suggested change
| {shouldShowWikiUrl(plugin.wiki?) && | |
| {shouldShowWikiUrl(plugin.wiki || {}) && |
or we fix it upstream in the source plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the annoyingly frequent
shouldShowWikiUrlnull error