Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode #1556

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Add dark mode #1556

merged 4 commits into from
Dec 21, 2023

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Nov 1, 2023

Fixes #1146

Before merging the header component should be updated.

@zbynek zbynek requested a review from a team as a code owner November 1, 2023 08:12
@zbynek zbynek mentioned this pull request Nov 8, 2023
Closed
timja
timja approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to me :) (tested in the deploy-preview), can be tweaked later.

Thanks for this!

@timja timja merged commit 68b9931 into jenkins-infra:master Dec 21, 2023
13 checks passed
@zbynek zbynek deleted the dark-mode branch December 21, 2023 11:28
@NotMyFault
Copy link
Member

I'm late to the party but thanks for the PR!

I've tried it locally and found no issues so far. Looks really good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@NotMyFault NotMyFault Awaiting requested review from NotMyFault

@halkeye halkeye Awaiting requested review from halkeye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a darkmode
4 participants
@zbynek @NotMyFault @halkeye @timja