Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clustering documentation #11

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Add clustering documentation #11

merged 1 commit into from
Jun 13, 2018

Conversation

amclain
Copy link
Contributor

@amclain amclain commented Jun 8, 2018

This PR adds documentation containing a description of Jylis' clustering, as well as a practical example.


* `--addr` (`-a`) - The `host:port:name` to be advertised to other clustering nodes.
* `--seed-addrs` (`-s`) - A space-separated list of the `host:port:name` for other known nodes.
* `--heartbeat-time` (`-H`) - The number of seconds between heartbeats in the clustering protocol.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the roadmap (#1), these clustering setup options are going to change soon. I think they are missing some needed features for flexibility, and I want to generally confirm that everything is as it should be in the 1.0 version. That's why I was a bit hesitant to write documentation about this.

However, I suppose that having some documentation about the current clustering setup options is better than having nothing. These docs can be updated when changes occur.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I suppose that having some documentation about the current clustering setup options is better than having nothing.

That was my thought. It wasn't inherently obvious from the current documentation that clustering was possible or what options I needed to use to do it.

These docs can be updated when changes occur.

👍 I can certainly help with that as well if necessary.

- "--addr=db2:9999:db2"
- "--seed-addrs=db1:9999:db1 db3:9999:db3"
links:
- db1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to link to db3 here, for docker to let us resolve the db3 hostname?

Similarly, do we need to add links for db2 and db3 in the db1 stanza above?

I don't remember whether docker will let us resolve the others by hostname unless the are linked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are bidirectional and Docker also uses them to build a dependency tree. Adding the extra links results in: ERROR: Circular dependency between db3 and db2.

@jemc jemc merged commit 5e15246 into jemc:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants