Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate setup.py to pyproject.toml #1472

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deronnax
Copy link

@deronnax deronnax commented Jan 3, 2025

an initiative of my own.

@deronnax deronnax requested a review from jelmer as a code owner January 3, 2025 22:11
tests_require.extend(["gevent", "geventhttpclient", "setuptools>=17.1"])


optional = os.environ.get("CIBUILDWHEEL", "0") != "1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this behaviour preserved?

optional = os.environ.get("CIBUILDWHEEL", "0") != "1"

# Ideally, setuptools would just provide a way to do this
if "PURE" in os.environ or "--pure" in sys.argv:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, please preserve support for the --puro flag and PURE environment variable.

else:
setup_requires = ["setuptools_rust"]
# We check for egg_info since that indicates we are running prepare_metadata_for_build_*
if "egg_info" in sys.argv:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@deronnax deronnax marked this pull request as draft January 4, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants