-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate setup.py to pyproject.toml #1472
base: master
Are you sure you want to change the base?
Conversation
tests_require.extend(["gevent", "geventhttpclient", "setuptools>=17.1"]) | ||
|
||
|
||
optional = os.environ.get("CIBUILDWHEEL", "0") != "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this behaviour preserved?
optional = os.environ.get("CIBUILDWHEEL", "0") != "1" | ||
|
||
# Ideally, setuptools would just provide a way to do this | ||
if "PURE" in os.environ or "--pure" in sys.argv: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well, please preserve support for the --puro flag and PURE environment variable.
else: | ||
setup_requires = ["setuptools_rust"] | ||
# We check for egg_info since that indicates we are running prepare_metadata_for_build_* | ||
if "egg_info" in sys.argv: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
an initiative of my own.