fix(present): bug with Qt and Windows + debug messages #377
Conversation
Apparently, the "recommended* versions of Qt (i.e., Qt 6.5.1 and 6.5.2) produces errors. I could not exactly re-produce #315, but I also have `failed to get textures for frame; format: 172 textureConverter null` in the output, as #315 (comment) mentioned. After searching a bit, this feels like the faulty lines are (at least related to) https://github.com/jeertmans/manim-slides/blob/1dbd2fdde58030867f15d7bf0ecede11d59d6903/manim_slides/present/player.py#L245-L247. I could not yet find a fix for that, but I created this PR for testing purposes... I also added quite a few debug prints, for the future. When upgrading Qt to 6.5.3 and above, the error message disappear, but we then have the same visual issue as described in #293.
jeertmans
added
bug
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 79.75% 79.19% -0.57%
==========================================
Files 22 22
Lines 1803 1836 +33
==========================================
+ Hits 1438 1454 +16
- Misses 365 382 +17 ☔ View full report in Codecov by Sentry. |
|
Hey jeertmans, you might not remember me but I spoke with you on discord about a month ago about this issue. I know it's been a while but I was just wondering if there was any update as to how to get this working, if I should change pyside6 versions, change over to pyqt6, or install a different version of manim-slides entirely. If there is nothing and I do end up having to change my version of manim-slides, can you let me know what version to install and which qt bindings to install with it? Thanks |
Hi @pianoboy71! Unfortunately, I did not try anything further, as I am quite busy with my research work, and I am not an active Windows user :-/ Maybe installing it through WSL on Windows might be a "fix", but I hope to come with a better fix one day. If anyone is willing to put some time to help on this issue, please do so! |
|
Perhaps of little value, but I've noticed that using |
Indeed, the fact that the info window duplicate the video stream seems to crash the app, and a solution seems to be to hide it from the start. I'd love to provide a better fix, but thank you for mentioning it :-) |
|
Let me know if you've come across any other fixes as I am using your excellent library on Windows right now. I'd love to contribute if I ever find the time to do so :) |
Well, if you have some time, I'd love to get your help on Windows (see my message on Reddit)! I think that, features-wise, Manim Slides is quite stable (at least the v6 will need (1) the Qt issue to be fixed (https://bugreports.qt.io/browse/QTBUG-118501) and also fixing any issue regarding incompatible Qt / Python version / OS triplets. If you feel confident, I suggest you fork and clone this repo, checkout this branch, and start modifying Another neat thing would be to create tests that capture those failing tasks, so we can actually test future fixes! Please let me know if you ever need help! |
|
Closing this PR (and related issue) as it does not seem to be needed anymore, as of #465. |
Apparently, the "recommended* versions of Qt (i.e., Qt 6.5.1 and 6.5.2) produces errors.
I could not exactly re-produce #315, but I also have
failed to get textures for frame; format: 172 textureConverter nullin the output, as #315 (comment) mentioned.After searching a bit, this feels like the faulty lines are (at least related to)
manim-slides/manim_slides/present/player.py
Lines 245 to 247 in 1dbd2fd
I could not yet find a fix for that, but I created this PR for testing purposes... I also added quite a few debug prints, for the future.
When upgrading Qt to 6.5.3 and above, the error message disappear, but we then have the same visual issue as described in #293.
This is the logs when I comment the lines mentioned:
If I put the lines back, the message is:
Now with
PySide6==6.5.3: