Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Slides go black when video finishes #293

Closed
jeertmans opened this issue Oct 19, 2023 · 1 comment · Fixed by #297, #464 or #465
Closed

[BUG] Slides go black when video finishes #293

jeertmans opened this issue Oct 19, 2023 · 1 comment · Fixed by #297, #464 or #465
Labels
bug Something isn't working present Related to the main "present" feature qt Related to Qt (or its Python binding)

Comments

@jeertmans
Copy link
Owner

jeertmans commented Oct 19, 2023 •
edited
Loading

Edit

This issue is tracked here: https://bugreports.qt.io/browse/QTBUG-118501.

In the meantime, #465 provides a fix that will be released with Manim Slides versions >5.1.7.

Description

When presenting non-looping slides, each slide goes to black when the video has finished playing.

This is a visual issue because transition are therefore brutal.

I have reached the PySide6 community for help, waiting for a response: https://forum.qt.io/topic/151237/qmediaplayer-stopping-on-last-frame.

Version

v5

Platform

Linux

Screenshots

No response

Additional information

No response
@jeertmans jeertmans added bug Something isn't working present Related to the main "present" feature labels Oct 19, 2023
@jeertmans
Copy link
Owner Author

This is apparently a bug introduced in PySide6 v6.5.3, I will force the PySide6 version and wait for a bug fix or response from Qt.

jeertmans added a commit that referenced this issue Oct 23, 2023
@jeertmans
fix(deps): PySide6 player black screen
cfcc8d0 
Fixes #293
@jeertmans jeertmans mentioned this issue Oct 23, 2023
Merged
jeertmans added a commit that referenced this issue Oct 23, 2023
@jeertmans
fix(deps): PySide6 player black screen (#297)
56b1ffe 
Fixes #293
@jeertmans jeertmans mentioned this issue Nov 20, 2023
Closed
@jeertmans jeertmans mentioned this issue Jan 12, 2024
Closed
@mmcilree mmcilree mentioned this issue Jan 29, 2024
Closed
@jeertmans jeertmans mentioned this issue Feb 12, 2024
Closed
@jeertmans jeertmans mentioned this issue Feb 22, 2024
Closed
jeertmans added a commit that referenced this issue Feb 27, 2024
@jeertmans
fix(present): bug with Qt and Windows + debug messages
d58af3a 
Apparently, the "recommended* versions of Qt (i.e., Qt 6.5.1 and 6.5.2) produces errors.

I could not exactly re-produce #315, but I also have `failed to get textures for frame; format: 172 textureConverter null` in the output, as #315 (comment) mentioned.

After searching a bit, this feels like the faulty lines are (at least related to) https://github.com/jeertmans/manim-slides/blob/1dbd2fdde58030867f15d7bf0ecede11d59d6903/manim_slides/present/player.py#L245-L247.

I could not yet find a fix for that, but I created this PR for testing purposes... I also added quite a few debug prints, for the future.

When upgrading  Qt to 6.5.3 and above, the error message disappear, but we then have the same visual issue as described in #293.
@jeertmans jeertmans mentioned this issue Feb 27, 2024
Closed
@jeertmans jeertmans pinned this issue Apr 8, 2024
@jeertmans jeertmans changed the title [BUG] Slides go black when video [BUG] Slides go black when video finishes Apr 8, 2024
@jeertmans jeertmans added the qt Related to Qt (or its Python binding) label Apr 8, 2024
@Judafa Judafa mentioned this issue May 9, 2024
Closed
@mateuszdrwal mateuszdrwal mentioned this issue May 22, 2024
Open
PeculiarProgrammer added a commit to PeculiarProgrammer/manim-slides that referenced this issue Aug 23, 2024
@PeculiarProgrammer
Fix for jeertmans#293 and similar errors
517fbc6 
This commit fixes the screen going black after the video ends in versions of PySide6 v6.5.3 and newer. This allows for other errors (like jeertmans#315) that require a newer version of PySide6 to also be fixed.
This was linked to pull requests Aug 26, 2024
fix(present): black video flashes and other bugs linked to Qt (original PR) #464
Merged
fix(present): black video flashes and other bugs linked to Qt #465
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working present Related to the main "present" feature qt Related to Qt (or its Python binding)
Projects
None yet
Milestone
No milestone
1 participant
@jeertmans