Add functions to delete filters from an interface #95
Conversation
Adding a delete function at runtime allows the babeld ipc to add and remove interfaces with filters. Further, it also allows more dynamic routing selection. Signed-off-by: Nick Hainke <[email protected]>
|
I'm extremely confused. This PR appears to add two functions that are not used anywhere. Is part of the patch missing? |
|
It's used by the IPC I added in openwrt: |
|
I see. It feels weird to add dead code to babeld, so I'm hesitating between adding the funcitonality to babeld's native IPC, or to ask you to maintain it in your fork. Do you have any opinions? |
|
I can maintain it as patch. I just wanted to get some feedback from you if I can do such things. :) |
|
The code looks good to me. Perhaps you could explain why you need this functionality, so we can think together whether there's a better solution to your problem? |
|
I'm adding and removing dynamically interfaces. Sometimes they even have the same name. I'm also adding filters on them. When I remove now an interface, I want to also to remove the filters. Maybe a clean removing of an interface and its filters would be some good solution for me. |
|
Maybe a clean removing of an interface and its filters would be some
good solution for me.
You got it. Give me a few days.
|
|
Thanks! :) |
|
Any news? :) |
Adding a delete function at runtime allows the babeld ipc to add and remove interfaces with filters. Further, it also allows more dynamic routing selection.