fix: imageSize=0无效 #2937
Merged
fix: imageSize=0无效 #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
变更概述演练此次变更主要修改了 变更
可能相关的 PR
建议标签
建议审阅者
诗歌庆祝
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/packages/empty/empty.taro.tsx (1)
Line range hint
72-84: 实现与非 Taro 版本保持一致！Taro 版本的改动与标准版本完全一致，确保了跨平台行为的一致性。实现方式合理，完全解决了
imageSize=0的问题。建议：
考虑将这个通用的类型检查逻辑抽取到 utils 文件中，以避免代码重复，提高维护性。// 建议在 utils.ts 中添加： + export const getImageSizeStyle = (imageSize: number | string) => { + if (typeof imageSize !== 'number' && typeof imageSize !== 'string') { + return {} + } + if (typeof imageSize === 'number') { + return { + width: `${imageSize}px`, + height: `${imageSize}px`, + } + } + return { + width: imageSize, + height: imageSize, + } + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/packages/empty/empty.taro.tsx(1 hunks)src/packages/empty/empty.tsx(1 hunks)
🔇 Additional comments (1)
src/packages/empty/empty.tsx (1)
Line range hint
74-86: 类型检查逻辑优化得当！新的类型检查逻辑解决了
imageSize=0无效的问题，同时保持了对字符串类型的兼容性。代码结构清晰，类型判断准确。以下是具体改进：
- 通过显式的类型检查替代了原来的真值判断，避免了 0 被错误地判断为假值
- 分别处理了数字和字符串两种有效类型
- 对于无效类型返回空对象，确保了组件的健壮性
oasis-cloud
approved these changes
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2937 +/- ##
==========================================
+ Coverage 84.02% 84.03% +0.01%
==========================================
Files 220 220
Lines 17917 17917
Branches 2628 2628
==========================================
+ Hits 15055 15057 +2
+ Misses 2857 2855 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
背景： Empty设置imageSize=0无效
解决：
判断条件改为
typeof imageSize !== 'number' && typeof imageSize !== 'string'☑️ 请求合并前的自查清单
Summary by CodeRabbit
imageSize为数字或字符串时正确设置图像样式。