fix making one too many "vscreens" in extend case #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
growing the number (set vscreens N) at runtime would always grow one extra: new set of vscreens had the last one indexed at N, rather than N-1. this meant there was always one extra when we grew the vscreen count. the end must be shifted by one left. conversely, shrinking already worked correctly: the new set of vscreens would have the last one indexed at N-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extend code keeps counting by N but N is a count, not an index. Index numbers should be considered as shifted by one from count numbers. Result is growing (requested "vscreens" value larger than currently configured one) will end up making one too many. Shrinking already works correctly.