Rename from Heroicon to Heroicons and lots of clean up
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_deps * ben/reduce-rails-deps: ignore Gemfile.lock remove Gemfile.lock remove remaining rails dependencies and isolate down to railties remove activejob remove actionmailer remove activestorage remove actiontext remove actionmailbox remove actioncable add Gemfile to track rails deps reduction
**Breaking Changes:**: `Heroicon` has been renamed to `Heroicons`. This only impacts the namespace and not the actual helper. The helper remains as `heroicon`. **Other Changes:** - No longer need to generate helper which includes the engine. We simply hook into `ActiveSupport.on_load` to make `heroicon` work. - Eliminated a lot of uncessary stuff and simplified the gem a bit. - Updated the CI
jclusso
changed the title
Heroicon to Heroicons and lots of clean up
|
@simmerz sorry for requesting the review. Just noticed the CI failing. Odd error I'm not familiar with. Don't have a lot of experience using Appraisals. |
- Drop support for ancient Ruby and Rails versions. Only supporting Ruby 2.7+ and Rails 6.1+ going forward.
|
I got it all working. If you have a chance, let me know your thoughts @simmerz! |
…g actually has changed with icons since 2.1.1.
|
Nice work. Looks good to me. I've not done a lot with Appraisals either, but it all makes sense :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes:
Heroiconhas been renamed toHeroicons. This only impacts the namespace and not the actual helper. The helper remains asheroicon.Users will need to do the following:
helpers/heroicon_helper.rbinitializers/heroicon.rbtoinitializers/heroicons.rband updateHeroicon.configure...toHeroicons.configure....Drop support below Ruby 2.7 and Rails 6.1.
Other Changes:
ActiveSupport.on_loadto makeheroiconwork.