Update Rubocop config, fix offenses

jbox-web · Aug 29, 2024 · 0983111 · 0983111
1 parent 438422f
commit 0983111
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 18 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,12 +1,16 @@
+---
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
+  - rubocop-rspec_rails
+
 AllCops:
   NewCops: enable
-  SuggestExtensions: false
   TargetRubyVersion: '3.0'
   Exclude:
     - bin/*
-
-Gemspec/DevelopmentDependencies:
-  Enabled: false
+    - lib/datatables-factory.rb
 
 Gemspec/RequireMFA:
   Enabled: false
@@ -57,13 +61,6 @@ Layout/HashAlignment:
 Metrics/MethodLength:
   Max: 12
 
-Metrics/ModuleLength:
-  Max: 140
+Metrics/ClassLength:
+  Max: 110
 
-##########
-# NAMING #
-##########
-
-Naming/FileName:
-  Exclude:
-    - lib/datatables-factory.rb
diff --git a/Gemfile b/Gemfile
@@ -10,5 +10,9 @@ gem 'pry'
 gem 'rake'
 gem 'rspec-rails'
 gem 'rubocop'
+gem 'rubocop-performance'
+gem 'rubocop-rake'
+gem 'rubocop-rspec'
+gem 'rubocop-rspec_rails'
 gem 'simplecov'
 gem 'sqlite3', '~> 1.5.0'
diff --git a/lib/datatables_factory/presenter.rb b/lib/datatables_factory/presenter.rb
@@ -52,8 +52,8 @@ def search_form(options = {}, &block)
       options[:html]             ||= {}
       options[:html][:role]      ||= 'form'
       options[:layout]           ||= :horizontal
-      options[:acts_like_form_tag] =   true
-      options[:datatable]          =   self
+      options[:acts_like_form_tag] = true
+      options[:datatable]          = self
 
       layout = "form-#{options[:layout]}"
       options[:html][:class] = [options[:html][:class], layout].compact.join(' ')
@@ -106,7 +106,7 @@ def datatable_id
 
 
       def final_namespace
-        @final_namespace ||= @namespace.prepend(:datatables).map(&:to_s).map(&:camelize)
+        @final_namespace ||= @namespace.prepend(:datatables).map { |x| x.to_s.camelize }
       end
 
 

diff --git a/lib/datatables_factory/view_helper.rb b/lib/datatables_factory/view_helper.rb
@@ -47,7 +47,7 @@ def datatable_options_for_range_date
 
     def label_filter_by(label, prefix: true)
       label  = t("datatables.filter.#{label}")
-      label  = prefix ? label.downcase : label
+      label  = label.downcase if prefix
       prefix = prefix ? "#{t('text.filter_by')} " : ''
       "#{prefix}#{label}"
     end
@@ -80,7 +80,7 @@ def datatables_translations
           rows: t('datatables.select.rows'),
         },
         buttons:        {
-          pageLength: {
+          pageLength:    {
             _:    t('datatables.buttons.pageLength._'),
             '-1': t('datatables.buttons.pageLength.-1'),
           },