Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SET-626 Olympus - Ensure Ansible updates Nginx images #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SET-626 Olympus - Ensure Ansible updates Nginx images #237

wants to merge 1 commit into from

Conversation

RanabirChakraborty
Copy link
Contributor

spyrkob
spyrkob reviewed Feb 15, 2024
View reviewed changes
roles/nginx/tasks/nginx_update.yml Outdated

- name: Store current nginx image value in a variable
set_fact:
nginx_latest_image_tag: "{{ local_image_tags.results[0].images[0].RepoTags[0] }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC that assumes that nginx is always the first result returned, is that correct?

If so, that works currently because it's the only remote image, but if we add a new remote image wouldn't this start failing in unexpected ways?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Modified the PR accordingly.

roles/nginx/tasks/nginx_update.yml
nginx_latest_image_tag: "{{ local_image_tags.results[0].images[0].RepoTags[0] }}"

- name: Pull the latest Nginx image
shell: "podman pull {{ nginx.latest_image }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something, but where is the nginx.latest_image defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed adding the vars. modified it.

@rpelisse
Copy link
Collaborator

@RanabirChakraborty I still need to find some time to review this, but, in the meantime, can you rebase and push?

@RanabirChakraborty
Copy link
Contributor Author

@rpelisse thanks! I have done the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spyrkob spyrkob spyrkob left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RanabirChakraborty @rpelisse @spyrkob