Fix CI errors

jboss-set · Jan 9, 2025 · cd443a8 · cd443a8
1 parent 1b69110
commit cd443a8
Show file tree

Hide file tree

Showing 41 changed files with 19 additions and 40 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,8 @@
 Zeus
 ====
 
+[![Build Status](https://github.com/jboss-set/zeus/workflows/CI/badge.svg)](https://github.com/jboss-set/zeus/actions/workflows/ci.yml)
+
 These are Ansible configuration scripts for the Olympus JBoss SET CI server.
 
 ### Prerequisites:

diff --git a/molecule/account/molecule.yml b/molecule/account/molecule.yml
@@ -3,7 +3,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/account/prepare.yml b/molecule/account/prepare.yml
@@ -2,7 +2,12 @@
 - name: Prepare
   hosts: all
   gather_facts: yes
+  vars_files:
+    - vars.yml
   tasks:
 
     - name: "Include common prepare tasks"
       ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ account.username }}"
diff --git a/molecule/account/verify.yml b/molecule/account/verify.yml
@@ -1,7 +1,6 @@
 ---
 - name: Verify for account role
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   gather_facts: false

diff --git a/molecule/aphrodite/converge.yml b/molecule/aphrodite/converge.yml
@@ -1,7 +1,6 @@
 ---
 - name: Converge
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
 

diff --git a/molecule/aphrodite/molecule.yml b/molecule/aphrodite/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/aphrodite/prepare.yml b/molecule/aphrodite/prepare.yml
@@ -15,7 +15,6 @@
           - { path: /opt/tools, owner: "{{ aphrodite_user }}", group: "{{ aphrodite_user }}" }
 
     - name: "Deploy aphrodite configuration to {{ aphrodite.path }}"
-      become: yes
       ansible.builtin.template:
         src: "../../roles/aphrodite/templates/aphrodite.json.j2"
         dest: "{{ aphrodite.path }}"

diff --git a/molecule/aphrodite/verify.yml b/molecule/aphrodite/verify.yml
@@ -1,7 +1,6 @@
 ---
 - name: Verify for aphrodite role
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   gather_facts: false

diff --git a/molecule/bashrc/molecule.yml b/molecule/bashrc/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/cron/molecule.yml b/molecule/cron/molecule.yml
@@ -3,7 +3,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/fast_yum_install/converge.yml b/molecule/fast_yum_install/converge.yml
@@ -1,7 +1,6 @@
 ---
 - name: Converge
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   tasks:

diff --git a/molecule/fast_yum_install/molecule.yml b/molecule/fast_yum_install/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/git/molecule.yml b/molecule/git/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/hosts/converge.yml b/molecule/hosts/converge.yml
@@ -1,7 +1,6 @@
 ---
 - name: Converge
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   tasks:

diff --git a/molecule/hosts/molecule.yml b/molecule/hosts/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/hosts/verify.yml b/molecule/hosts/verify.yml
@@ -1,14 +1,12 @@
 ---
 - name: Verify for hosts role
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   gather_facts: false
 
   tasks:
     - name: Add Ansible inventory mappings to /etc/fake_hosts
-      become: true
       ansible.builtin.blockinfile:
         path: "/etc/fake_hosts"
         block: |

diff --git a/molecule/java/molecule.yml b/molecule/java/molecule.yml
@@ -3,7 +3,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/kdump/converge.yml b/molecule/kdump/converge.yml
@@ -1,7 +1,6 @@
 ---
 - name: Converge
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   tasks:

diff --git a/molecule/kdump/molecule.yml b/molecule/kdump/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/kdump/verify.yml b/molecule/kdump/verify.yml
@@ -1,7 +1,6 @@
 ---
 - name: Verify for kdump role
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   gather_facts: false

diff --git a/molecule/motd/molecule.yml b/molecule/motd/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/motd/verify.yml b/molecule/motd/verify.yml
@@ -6,7 +6,6 @@
   gather_facts: yes
   tasks:
     - name: Add a duplicate motd
-      become: yes
       ansible.builtin.copy:
         src: "../../roles/motd/files/motd.standard"
         dest: /etc/duplicateMotd

diff --git a/molecule/netrc/converge.yml b/molecule/netrc/converge.yml
@@ -1,7 +1,6 @@
 ---
 - name: Converge
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   tasks:

diff --git a/molecule/netrc/molecule.yml b/molecule/netrc/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/netrc/verify.yml b/molecule/netrc/verify.yml
@@ -1,7 +1,6 @@
 ---
 - name: Verify for netrc role
   hosts: all
-  become: yes
   vars_files:
     - vars.yml
   gather_facts: false

diff --git a/molecule/prepare.yml b/molecule/prepare.yml
@@ -20,7 +20,6 @@
     loop_var: user
 
 - name: "Creates directory"
-  become: yes
   ansible.builtin.file:
     path: "{{ dir.path }}"
     state: "{{ dir.state | default('directory') }}"

diff --git a/molecule/qualys_fix/converge.yml b/molecule/qualys_fix/converge.yml
@@ -1,6 +1,5 @@
 ---
 - name: Converge
-  become: yes
   hosts: all
 
   tasks:

diff --git a/molecule/qualys_fix/molecule.yml b/molecule/qualys_fix/molecule.yml
@@ -9,7 +9,7 @@ driver:
   name: podman
 platforms:
   - name: instance
-    image: registry.access.redhat.com/ubi8/ubi-init:latest
+    image: registry.access.redhat.com/ubi9/ubi-init:latest
     pre_build_image: true
     privileged: true
     command: "/usr/sbin/init"

diff --git a/molecule/qualys_fix/verify.yml b/molecule/qualys_fix/verify.yml
@@ -5,7 +5,6 @@
 
   tasks:
     - name: "Escalate privileges"
-      become: yes
       block:
         - name: Add a duplicate Windows specific tasks
           ansible.builtin.template:

diff --git a/roles/account/tasks/main.yml b/roles/account/tasks/main.yml
@@ -13,7 +13,6 @@
     quiet: true
 
 - name: "Escalate privilege"
-  become: yes
   block:
     - name: "Ensure group {{ account.group }} exists."
       ansible.builtin.group:

diff --git a/roles/aphrodite/tasks/main.yml b/roles/aphrodite/tasks/main.yml
@@ -8,7 +8,6 @@
     quiet: true
 
 - name: "Deploy aphrodite configuration to {{ aphrodite.path }}"
-  become: yes
   ansible.builtin.template:
     src: "{{ aphrodite.template }}"
     dest: "{{ aphrodite.path }}"

diff --git a/roles/bashrc/tasks/main.yml b/roles/bashrc/tasks/main.yml
@@ -1,6 +1,5 @@
 ---
 - name: Check bashrc configuration
-  become: yes
   ansible.builtin.template:
     src: templates/bashrc.j2
     dest: /etc/bashrc

diff --git a/roles/cron/tasks/cronjob.yml b/roles/cron/tasks/cronjob.yml
@@ -11,7 +11,6 @@
     quiet: true
 
 - name: "Escalate privileges"
-  become: yes
   block:
     - name: "Ensures script job for {{ jobs.name }} is deployed"
       ansible.builtin.template:

diff --git a/roles/fast_yum_install/tasks/main.yml b/roles/fast_yum_install/tasks/main.yml
@@ -5,7 +5,6 @@
     quiet: true
 
 - name: "Escalate privileges"
-  become: yes
   block:
     - name: "Test if package {{ package_name }} is already installed"
       ansible.builtin.command: rpm -q {{ package_name }}

diff --git a/roles/git/tasks/main.yml b/roles/git/tasks/main.yml
@@ -5,7 +5,6 @@
     package_name: git
 
 - name: "Ensures gitconfig is deployed for user root"
-  become: yes
   ansible.builtin.template:
     src: templates/gitconfig.j2
     dest: "{{ config.home }}/.gitconfig"

diff --git a/roles/hosts/tasks/main.yml b/roles/hosts/tasks/main.yml
@@ -1,7 +1,6 @@
 ---
 - block:
   - name: Add Ansible inventory mappings to /etc/hosts
-    become: true
     ansible.builtin.blockinfile:
       path: "{{ hosts_path_to_file }}"
       block: |

diff --git a/roles/java/tasks/archive_tool_install.yml b/roles/java/tasks/archive_tool_install.yml
@@ -14,7 +14,6 @@
     path_to_archive: "{{ home_folder }}/{{ files.name }}{{ files.ext | default('.tgz') }}"
 
 - name: "Escalate priviliges"
-  become: yes
   block:
     - ansible.builtin.stat:
         path: "{{ path_to_archive }}"

diff --git a/roles/java/tasks/install_and_default.yml b/roles/java/tasks/install_and_default.yml
@@ -18,7 +18,6 @@
     loop_var: files
 
 - name: "Symlink {{ tool_default_link }} to default version: {{ tool_default }}."
-  become: yes
   ansible.builtin.file:
     src: "{{ tool_default }}"
     dest: "{{ tool_default_link }}"

diff --git a/roles/java/tasks/main.yml b/roles/java/tasks/main.yml
@@ -7,7 +7,6 @@
     quiet: true
 
 - name: "Ensures the tools home folder exits."
-  become: yes
   ansible.builtin.file:
     state: directory
     path: "{{ folders }}"

diff --git a/roles/motd/tasks/main.yml b/roles/motd/tasks/main.yml
@@ -10,7 +10,6 @@
     motd_src_file: "files/motd.{{ motd.font }}"
 
 - name: Add a specific motd
-  become: yes
   ansible.builtin.copy:
     src: "files/motd.{{ motd.font }}"
     dest: /etc/motd

diff --git a/roles/qualys_fix/tasks/main.yml b/roles/qualys_fix/tasks/main.yml
@@ -1,6 +1,5 @@
 ---
 - name: "Replace content of Windows specific tasks, that are not Ansible 2.21 compliant"
-  become: yes
   ansible.builtin.template:
     dest: "{{ tasks }}"
     src: templates/dummy.j2