Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️: bump to rc2 for new release to trigger release workflow #485

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

schlich
Copy link
Contributor

@schlich schlich commented Feb 28, 2024

No description provided.

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

the v4.0.0rc1 tag was already made with the first attempt at a release candidate (release workflow failed) -- the new GitHub release tag would have to be rc2. We could make the release rc2 on GitHub and rc1 on pyPI but that doens't make any sense.

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

@MrCordeiro let me know if that makes sense i'll wait to merge this time.

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

I guess I might be mistaken that you can't edit the tag on the GitHub Release. It seems like in the UI that the platform lets you edit it. If that's the case then you might be right and we can try that route.

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

never mind; it looks like you can only edit the notes for the release not the tag itself. We good @MrCordeiro ?

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

PS it looks like i tagged the wrong commit/branch in my terminal because i had forgotten that GH tags releases for us and thats why the workflow failed, not the syntax like i thought -- that was my mistake. And why i'm test running with release candidate. I tried to be careful; not sure how i tagged the wrong commit!

@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

I'll take your deleted comment as a 'good to go' -- let's touch base tomorrow about the full release; maybe you can handle it @MrCordeiro so i dont mess it up 😉

@schlich schlich merged commit def9657 into master Feb 28, 2024
13 checks passed
@schlich schlich deleted the 4.0rc2 branch February 28, 2024 08:27
@schlich
Copy link
Contributor Author

schlich commented Feb 28, 2024

PS another reason why i'm stumbling a little bit here is that i usually manage releases through python-semantic-release which automates much of the process. If i get the time i'd like to submit a PR implementing this to lessen maintenance burden just a little bit but obviously would need your sign off @MrCordeiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant