-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci and code #18
base: main
Are you sure you want to change the base?
Conversation
…tion and avoid duplicating code from django
Hi, Looks like we have introduced almost the same changes regarding the CI setup 😅 #19 Since your changeset covers a lot more, I'm happy to close my PR and wait for your changes to be merged. |
@sevdog @artursmet Thank you both! |
Seems that I forgot to explicity setup the codecov token for upload, the solution would be to add the that step (as pointed here) env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} Which is the name of the secret in which codecov token is stored? |
@sevdog I'm not code owner now and I can't change settings. So I don't really know if I can set up token.. 🙏 |
This PR performs some updates: