Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci and code #18

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

sevdog
Copy link

@sevdog sevdog commented Apr 9, 2024

This PR performs some updates:

  • Update CI to work on github actions rather than travis.ci
  • Add django 5.0 and python 3.11/3.12, remove python 3.7 from CI
  • Update codebase to better use python 3.8 features
  • Remove raw SQL formatting in tests (which is a bad practice)
  • Refactor encryption to reduce code redundancy in JSONField
  • Refactor validators definition for IntegerField to avoid copypasting code from django and to address connection specific limits

@artursmet
Copy link

Hi,

Looks like we have introduced almost the same changes regarding the CI setup 😅 #19 Since your changeset covers a lot more, I'm happy to close my PR and wait for your changes to be merged.

@frgmt
Copy link
Collaborator

frgmt commented Apr 9, 2024

@sevdog @artursmet Thank you both!

@sevdog
Copy link
Author

sevdog commented Apr 15, 2024

Seems that I forgot to explicity setup the codecov token for upload, the solution would be to add the that step (as pointed here)

      env:
        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Which is the name of the secret in which codecov token is stored?

@frgmt
Copy link
Collaborator

frgmt commented Apr 23, 2024

@sevdog I'm not code owner now and I can't change settings. So I don't really know if I can set up token.. 🙏
Should we ask the jazzband maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants