Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40 Replace plugins with a new routing API #41

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Conversation

dzikoysk
Copy link
Member

No description provided.

@dzikoysk
Copy link
Member Author

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #41 (b610d59) into main (8559cf8) will decrease coverage by 1.82%.
Report is 1 commits behind head on main.
The diff coverage is 92.23%.

@@             Coverage Diff              @@
##               main      #41      +/-   ##
============================================
- Coverage     80.54%   78.71%   -1.82%     
+ Complexity       83       81       -2     
============================================
  Files            20       21       +1     
  Lines           483      465      -18     
  Branches         63       63              
============================================
- Hits            389      366      -23     
- Misses           71       76       +5     
  Partials         23       23              
Files Coverage Δ
.../community/routing/annotations/AnnotatedRouting.kt 94.55% <100.00%> (ø)
...ty/routing/annotations/ReflectiveEndpointLoader.kt 73.29% <100.00%> (ø)
...alin/community/routing/JavalinRoutingExtensions.kt 83.34% <100.00%> (ø)
...in/io/javalin/community/routing/RouteComparator.kt 100.00% <ø> (ø)
.../kotlin/io/javalin/community/routing/RoutingApi.kt 0.00% <ø> (ø)
...javalin/community/routing/coroutines/Coroutines.kt 100.00% <100.00%> (ø)
...ty/routing/coroutines/servlet/CoroutinesServlet.kt 85.30% <100.00%> (ø)
...lin/io/javalin/community/routing/dsl/DslFactory.kt 92.31% <100.00%> (+5.13%) ⬆️
...lin/io/javalin/community/routing/dsl/DslRouting.kt 100.00% <100.00%> (ø)
...munity/routing/dsl/defaults/DefaultContextScope.kt 16.67% <ø> (ø)
... and 2 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dzikoysk dzikoysk marked this pull request as ready for review November 11, 2023 16:01
@dzikoysk dzikoysk merged commit 1ce4339 into main Nov 11, 2023
4 checks passed
@dzikoysk dzikoysk deleted the move-to-javalin6 branch November 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant